Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/remove client from basecoin #115

Merged
merged 21 commits into from
Jun 16, 2017
Merged

Feature/remove client from basecoin #115

merged 21 commits into from
Jun 16, 2017

Conversation

ethanfrey
Copy link
Contributor

Big overhaul here....

  • separated countercli out from basecli
  • cleaned up all basecli tx commands
  • added lots of new cli tests in tests/cli
  • removed old demo tests
  • removed example-plugin src
  • removed almost all "client" commands from basecoin, except basecoin tx ibc register

Still need to update the docs, but can do that in develop.

rigelrozanski and others added 21 commits June 16, 2017 13:38
@rigelrozanski @ethanfrey
makefile cleanup
e356fc1
@rigelrozanski @ethanfrey
circle bash integration
226546e
@ethanfrey
pulled out common helpers, prepare to support ibc
789ebad
@ethanfrey
Support other binaries
9341b8b
@ethanfrey
Added counter tests as well
81d6d24
@rigelrozanski @ethanfrey
makefile cleanup
ad17fcf 
int
@rigelrozanski @ethanfrey
reorganize basecli appTx commands
9c8ccef 
int
@ethanfrey
Merge pull request #111 from tendermint/apptxReorg
985db9c
@ethanfrey
Update CHANGELOG for some of the 0.6 enhancements
75425b9
@ethanfrey
Cache shunit2 in Makefile, so we don't wget everytime
4d41378
@ethanfrey
Create new command, countercli, removed counter from basecli
2f3c700
@ethanfrey
Fix cli tests for new countercli app
526e213
@ethanfrey
clean up cli tests
fb7fc78
@ethanfrey
Add ibc test scaffolding
4606fc8
@ethanfrey
Clear output of test failures in ibc
cba5523
@ethanfrey
basecli sendtx handles chain/addr format
33d4f93
@ethanfrey
Complete ibc tests with "basecoin ibc register" and "basecoin relay"
6eac364
@ethanfrey
Fix Makefile, remove no longer needed demo!
f75ebca
@ethanfrey
Ripped out query, tx send, account, keys, and more
b15f882
@ethanfrey
Removed many more unneeded commands
9bf34cb
@ethanfrey
Remove example-plugin code, need to fix docs
22918ba
@ethanfrey ethanfrey requested review from ebuchman and removed request for ebuchman June 16, 2017 15:38
This was referenced Jun 16, 2017
Closed
Closed
@ethanfrey ethanfrey merged commit 6c01988 into develop Jun 16, 2017
@ethanfrey ethanfrey deleted the feature/remove-client-from-basecoin branch June 16, 2017 15:40
liamsi pushed a commit to liamsi/cosmos-sdk that referenced this pull request Jun 26, 2018
@mossid @liamsi
Move from tmlibs cosmos#213 (cosmos#115)
66794a1 
* move from tmlibs 213
* expose KVPair, simpleproofsfrommap returns keys
ParthDesai pushed a commit to ChorusOne/cosmos-sdk that referenced this pull request Apr 19, 2021
@cwgoes
Merge PR cosmos#115: Document some design patterns
cea15ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanfrey @rigelrozanski