Tf upgrade #43
Merged
Tf upgrade #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of curiosity: @ejhumphrey @simondurand are either of you still interested in maintaining this? No problem if not, but I just want to get a sense of who's holding the bag here. |
|
I'll take three weeks of inactivity as tacit approval here. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependabot messages have really been getting to me lately.
This PR updates the openmic package to work with modern incarnations of tensorflow. No functional changes here other than running tf_upgrade_v2 and cleaning up the mess. I've also tweaked the dependencies in setup.py accordingly (soundfile instead of pysoundfile, added tf_slim, etc).
Probably we should merge this and tag a new release, but that's not urgent. I just wanted to get this branch out there for use in another project.