Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency hell #30

Open
ejhumphrey opened this issue Sep 19, 2018 · 4 comments
Open

dependency hell #30

ejhumphrey opened this issue Sep 19, 2018 · 4 comments

Comments

@ejhumphrey
Copy link
Contributor

In attempting to resolve a coverage / pytest-cov dependency issue (the base conda install wasn't leaving things in a working state), I've stepped on an even more annoying dependency problem in Python 3.4: https://travis-ci.com/cosmir/openmic-2018/jobs/146643891

tldr: tensorflow wants an old setuptools (<=39) while everything else is happy to move along to 40+. Thus, I have Questions:

  • Do we want to pin setuptools just to appease TF?
  • Do we really want to support 3.4?

@bmcfee I assume you have opinions?

@ejhumphrey
Copy link
Contributor Author

btw, to keep marching along, I'm going to disable 3.4 builds in the interim, since everything else is fine (minus a bunch of stdout vomit about deprecation warnings from TF)

@bmcfee
Copy link
Collaborator

bmcfee commented Sep 19, 2018

We don't need to support 3.4. Upgrading within the 3 series doesn't break anything, so it's not the same headache that 2<->3 is.

@ejhumphrey
Copy link
Contributor Author

sounds good, will uncomment and remove forevvver

@bmcfee
Copy link
Collaborator

bmcfee commented May 3, 2022

After merging #43 I can knock this one out by migrating the packaging up to the modern spec (setup.cfg, pyproject.toml, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants