-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update cortex dashboards #6288
update cortex dashboards #6288
Conversation
pulls in latest changes from cortex-jsonnet to update the dashboards in Grafana. also updates the alerting and recording rules. Signed-off-by: Charlie Le <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is very hard to review the dashboard change.
It would be great if you can attach relevant PRs in the cortex-jsonnet repo
@@ -254,7 +254,7 @@ groups: | |||
message: | | |||
Ingesters in {{ $labels.cluster }}/{{ $labels.namespace }} ingest too many samples per second. | |||
expr: | | |||
avg by (cluster, namespace) (rate(cortex_ingester_ingested_samples_total[1m])) > 80e3 | |||
avg by (cluster, namespace) (rate(cortex_ingester_ingested_samples_total[1m])) > 160e3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these default value changed due to values changed in the jsonnet repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's from cortexproject/cortex-jsonnet#60
@yeya24 Added changes to PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
pulls in latest changes from cortex-jsonnet to update the dashboards in Grafana. also updates the alerting and recording rules. Signed-off-by: Charlie Le <[email protected]>
pulls in latest changes from cortex-jsonnet to update the dashboards in Grafana. also updates the alerting and recording rules.
Changes:
timeseriesPanel
instead ofpanel
when creating panels cortex-jsonnet#58