Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cortex dashboards #6288

Merged

Conversation

CharlieTLe
Copy link
Member

@CharlieTLe CharlieTLe commented Oct 25, 2024

pulls in latest changes from cortex-jsonnet to update the dashboards in
Grafana. also updates the alerting and recording rules.

Signed-off-by: Charlie Le <[email protected]>
@CharlieTLe CharlieTLe requested a review from friedrichg October 25, 2024 21:22
@dosubot dosubot bot added the component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. label Oct 25, 2024
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is very hard to review the dashboard change.
It would be great if you can attach relevant PRs in the cortex-jsonnet repo

@@ -254,7 +254,7 @@ groups:
message: |
Ingesters in {{ $labels.cluster }}/{{ $labels.namespace }} ingest too many samples per second.
expr: |
avg by (cluster, namespace) (rate(cortex_ingester_ingested_samples_total[1m])) > 80e3
avg by (cluster, namespace) (rate(cortex_ingester_ingested_samples_total[1m])) > 160e3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these default value changed due to values changed in the jsonnet repo?

Copy link
Member Author

@CharlieTLe CharlieTLe Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CharlieTLe
Copy link
Member Author

@yeya24 Added changes to PR description.

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 7, 2024
Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@friedrichg friedrichg merged commit e6e62e3 into cortexproject:master Nov 8, 2024
16 checks passed
CharlieTLe added a commit to CharlieTLe/cortex that referenced this pull request Dec 3, 2024
pulls in latest changes from cortex-jsonnet to update the dashboards in
Grafana. also updates the alerting and recording rules.

Signed-off-by: Charlie Le <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. lgtm This PR has been approved by a maintainer size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants