forked from grafana/cortex-jsonnet
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase CortexProvisioningTooManyWrites alert threshold to 160k #60
Merged
friedrichg
merged 5 commits into
cortexproject:main
from
mvnarsing:update-too-many-writes-threshold
Sep 25, 2024
Merged
Increase CortexProvisioningTooManyWrites alert threshold to 160k #60
friedrichg
merged 5 commits into
cortexproject:main
from
mvnarsing:update-too-many-writes-threshold
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter (cortexproject#59) * Update CortexProvisioningTooManyActiveSeries to 3.2M series per ingester Signed-off-by: Friedrich Gonzalez <[email protected]> * Adjust more things Signed-off-by: Friedrich Gonzalez <[email protected]> * Update CHANGELOG.md --------- Signed-off-by: Friedrich Gonzalez <[email protected]> Signed-off-by: Narsing Metpally <[email protected]>
Signed-off-by: Narsing Metpally <[email protected]>
mvnarsing
force-pushed
the
update-too-many-writes-threshold
branch
from
September 24, 2024 19:00
bd97714
to
727addc
Compare
friedrichg
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. can you add a change in the CHANGELOG?
Signed-off-by: Narsing Metpally <[email protected]>
mvnarsing
force-pushed
the
update-too-many-writes-threshold
branch
from
September 25, 2024 18:36
ac70fdc
to
9acc487
Compare
friedrichg
previously approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
friedrichg
reviewed
Sep 25, 2024
friedrichg
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Proposing 2x increase in threshold limits based on our internal metrics we are able to handle around 160e3 samples with a CPU usage of about 2.5
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]