Introduce SkipBlocksWithOutOfOrderChunksEnabled feature #4707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanprot
reviewed
Apr 6, 2022
| @@ -2,533 +2,534 @@ | |||
|
|
|||
| ## master / unreleased | |||
|
|
|||
| * [FEATURE] Ruler: Add `external_labels` option to tag all alerts with a given set of labels. | |||
There was a problem hiding this comment.
seems that those changes were not intentional
There was a problem hiding this comment.
Oh this one is intentional because FEATURE should go after CHANGE (I as added the PR number)
There was a problem hiding this comment.
I will fix the unintended change (from '*' to '-' four bullets)
alanprot
approved these changes
Apr 6, 2022
Signed-off-by: Alvin Lin <[email protected]>
Signed-off-by: Alvin Lin <[email protected]>
Signed-off-by: Alvin Lin <[email protected]>
Signed-off-by: Alvin Lin <[email protected]>
Signed-off-by: Alvin Lin <[email protected]>
Signed-off-by: Alvin Lin <[email protected]>
Signed-off-by: Alvin Lin <[email protected]>
alvinlin123
force-pushed
the
allow-skip-blick-compation
branch
from
357881f
to
a09558c
Compare
Signed-off-by: Alvin Lin <[email protected]>
|
LGTM |
2 tasks
3 tasks
2 tasks
3 tasks
alanprot
pushed a commit
that referenced
this pull request
May 11, 2022
Signed-off-by: Friedrich Gonzalez <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alvin Lin [email protected]
What this PR does:
This PR allows user to configure if they want to skip out of order chunks during compaction (special thanks to @alanprot working on #4706 concurrently).
This PR also allows manual creation of
no-compact-mark.json.Which issue(s) this PR fixes:
Fixes #4692
Partially addresses #4705 - this change will allow manual creation of
no-compact-mark.jsonChecklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]