Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compactor - skipping out-of-order blocks feature is disabled #4692

Closed
shybbko opened this issue Mar 30, 2022 · 0 comments · Fixed by #4707
Closed

Compactor - skipping out-of-order blocks feature is disabled #4692

shybbko opened this issue Mar 30, 2022 · 0 comments · Fixed by #4707

Comments

@shybbko
Copy link

shybbko commented Mar 30, 2022

There is a PR to introduce Thanos feature of skipping out of order blocks #4453. It was raised late August 2021 and has stayed open ever since.
However there was yet another PR raised later (I believe "later" being an important factor here), namely in October 2021 #4505 that got merged and introduced that feature, however hardcoded it to be disabled: https://github.com/cortexproject/cortex/blob/release-1.11/pkg/compactor/compactor.go#L660.

Why is that so? Is the code only partially ready for this feature to be enabled? What would be required in order for that feature to be enabled for Cortex? I believe there are at least several issues / people that would benefit from it (myself included).

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant