You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a PR to introduce Thanos feature of skipping out of order blocks #4453. It was raised late August 2021 and has stayed open ever since.
However there was yet another PR raised later (I believe "later" being an important factor here), namely in October 2021 #4505 that got merged and introduced that feature, however hardcoded it to be disabled: https://github.com/cortexproject/cortex/blob/release-1.11/pkg/compactor/compactor.go#L660.
Why is that so? Is the code only partially ready for this feature to be enabled? What would be required in order for that feature to be enabled for Cortex? I believe there are at least several issues / people that would benefit from it (myself included).
Thanks.
The text was updated successfully, but these errors were encountered:
There is a PR to introduce Thanos feature of skipping out of order blocks #4453. It was raised late August 2021 and has stayed open ever since.
However there was yet another PR raised later (I believe "later" being an important factor here), namely in October 2021 #4505 that got merged and introduced that feature, however hardcoded it to be disabled: https://github.com/cortexproject/cortex/blob/release-1.11/pkg/compactor/compactor.go#L660.
Why is that so? Is the code only partially ready for this feature to be enabled? What would be required in order for that feature to be enabled for Cortex? I believe there are at least several issues / people that would benefit from it (myself included).
Thanks.
The text was updated successfully, but these errors were encountered: