-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally pass cortex config as configmap. #280
Conversation
dfc2be0
to
d2caf18
Compare
Nice! with that approach however, we should really have the s3 credentials (or similiar) not in the configMap. I'm not saying Secrets are "secure" but atleast you can install some KMS provider where you can actually encrypt the data. But with extraVolumes, extraVolumeMounts, extraEnvs and extraArgs this should already be possible. I would have to test that but I think you can already have sensitive information separately. Use environment variables in the configuration |
d2caf18
to
66e9ce3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thank you for your contribution.
Can you please add the CHANGELOG.md entry?
Also we would need to add a mechanism similiar to: This
We should also have ci-tests setup and documentation guide for proper usage so nobody puts their secrets in the configmap
So we can restart components when configmap changes, right now we can't use something like configmap reloader AFAIK
66e9ce3
to
a3c2cfe
Compare
Updated, lmk if I missed anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have another glance tomorrow but this looks really good. Thanks!
a3c2cfe
to
54800a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-edited the guide, because inline code blocks completely broke the the text unfortunately. We will have to adjust the markdown processor or something like that in the future
Fixes cortexproject#235. Signed-off-by: Josh Carp <[email protected]>
c8d57c4
to
bdc12f7
Compare
@jmcarp Please be careful when rebasing, my changes to the guide were lost 😢 |
Signed-off-by: ShuzZzle <[email protected]>
Signed-off-by: ShuzZzle <[email protected]>
15b3959
to
6846cea
Compare
Ack, sorry, not used to collaborating on a branch 😓 |
What this PR does:
Optionally pass cortex config as configmap.
Note: I only updated the ingestor templates so far, to verify that the approach makes sense. If it does, I'll copy and paste the updated volume to the other templates.
Which issue(s) this PR fixes:
Fixes #235.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]