Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy the config as a configMap rather than a secret #235

Closed
nschad opened this issue Oct 5, 2021 · 1 comment · Fixed by #280
Closed

Deploy the config as a configMap rather than a secret #235

nschad opened this issue Oct 5, 2021 · 1 comment · Fixed by #280
Labels
keepalive Keeps Issue's from beeing closed

Comments

@nschad
Copy link
Collaborator

nschad commented Oct 5, 2021

Let's also add the ability to deploy the config as a configMap rather than a secret?

Originally posted by @cabrinha in #227 (comment)

And have the credentials passed as environment variables backed by secrets? That would be quite optimal.
@nschad nschad changed the title Deploy the config as a configMap rather than a secret? Deploy the config as a configMap rather than a secret Oct 5, 2021
@stale
Copy link

stale bot commented Nov 8, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 8, 2021
@nschad nschad added the keepalive Keeps Issue's from beeing closed label Nov 8, 2021
@stale stale bot closed this as completed Nov 24, 2021
@cabrinha cabrinha reopened this Nov 24, 2021
@stale stale bot removed the stale label Nov 24, 2021
jmcarp added a commit to jmcarp/cortex-helm-chart that referenced this issue Dec 1, 2021
@jmcarp
Optionally pass cortex config as configmap.
29b9d7c 
Fixes cortexproject#235.
@jmcarp jmcarp mentioned this issue Dec 1, 2021
Merged
1 task
jmcarp added a commit to jmcarp/cortex-helm-chart that referenced this issue Dec 1, 2021
@jmcarp
Optionally pass cortex config as configmap.
d05cf5f 
Fixes cortexproject#235.
jmcarp added a commit to jmcarp/cortex-helm-chart that referenced this issue Dec 1, 2021
@jmcarp
Optionally pass cortex config as configmap.
9dc4312 
Fixes cortexproject#235.

Signed-off-by: Josh Carp <[email protected]>
jmcarp added a commit to jmcarp/cortex-helm-chart that referenced this issue Dec 1, 2021
@jmcarp
Optionally pass cortex config as configmap.
48352bf 
Fixes cortexproject#235.

Signed-off-by: Josh Carp <[email protected]>
jmcarp added a commit to jmcarp/cortex-helm-chart that referenced this issue Dec 2, 2021
@jmcarp
Optionally pass cortex config as configmap.
e68d0a5 
Fixes cortexproject#235.

Signed-off-by: Josh Carp <[email protected]>
jmcarp added a commit to jmcarp/cortex-helm-chart that referenced this issue Dec 2, 2021
@jmcarp
Optionally pass cortex config as configmap.
439d1ba 
Fixes cortexproject#235.

Signed-off-by: Josh Carp <[email protected]>
jmcarp added a commit to jmcarp/cortex-helm-chart that referenced this issue Dec 2, 2021
@jmcarp
Optionally pass cortex config as configmap.
c3027cc 
Fixes cortexproject#235.

Signed-off-by: Josh Carp <[email protected]>
jmcarp added a commit to jmcarp/cortex-helm-chart that referenced this issue Dec 2, 2021
@jmcarp
Optionally pass cortex config as configmap.
dfc2be0 
Fixes cortexproject#235.

Signed-off-by: Josh Carp <[email protected]>
jmcarp added a commit to jmcarp/cortex-helm-chart that referenced this issue Dec 2, 2021
@jmcarp
Optionally pass cortex config as configmap.
d2caf18 
Fixes cortexproject#235.

Signed-off-by: Josh Carp <[email protected]>
jmcarp added a commit to jmcarp/cortex-helm-chart that referenced this issue Dec 3, 2021
@jmcarp
Optionally pass cortex config as configmap.
66e9ce3 
Fixes cortexproject#235.

Signed-off-by: Josh Carp <[email protected]>
jmcarp added a commit to jmcarp/cortex-helm-chart that referenced this issue Dec 5, 2021
@jmcarp
Optionally pass cortex config as configmap.
a3c2cfe 
Fixes cortexproject#235.

Signed-off-by: Josh Carp <[email protected]>
jmcarp added a commit to jmcarp/cortex-helm-chart that referenced this issue Dec 5, 2021
@jmcarp
Optionally pass cortex config as configmap.
54800a9 
Fixes cortexproject#235.

Signed-off-by: Josh Carp <[email protected]>
jmcarp added a commit to jmcarp/cortex-helm-chart that referenced this issue Dec 6, 2021
@jmcarp
Optionally pass cortex config as configmap.
bdc12f7 
Fixes cortexproject#235.

Signed-off-by: Josh Carp <[email protected]>
nschad added a commit that referenced this issue Dec 6, 2021
@jmcarp @nschad
Optionally pass cortex config as configmap. (#280)
731c145 
* Optionally pass cortex config as configmap.

Fixes #235.

Signed-off-by: Josh Carp <[email protected]>

* rework format for guide section

Signed-off-by: ShuzZzle <[email protected]>

* fix config volume name

Signed-off-by: ShuzZzle <[email protected]>

Co-authored-by: ShuzZzle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
keepalive Keeps Issue's from beeing closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optionally pass cortex config as configmap. jmcarp/cortex-helm-chart
2 participants
@cabrinha @nschad