Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Support pandas IntegerArray #158

Merged
merged 1 commit into from
Jan 16, 2024
Merged

BUG: Support pandas IntegerArray #158

merged 1 commit into from
Jan 16, 2024

Conversation

snowman2
Copy link
Member

Error encountered without the fix:

TypeError: Cannot interpret 'Int64Dtype()' as a data type

@snowman2 snowman2 added the bug Something isn't working label Jan 16, 2024
@snowman2 snowman2 added this to the 0.4.2 milestone Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d39758e) 97.02% compared to head (ef16eef) 97.26%.

❗ Current head ef16eef differs from pull request most recent head e5e5a14. Consider uploading reports for the commit e5e5a14 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   97.02%   97.26%   +0.23%     
==========================================
  Files          14       14              
  Lines         437      438       +1     
==========================================
+ Hits          424      426       +2     
+ Misses         13       12       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@alfredoahds alfredoahds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Is this something we're seeing now due to a version upgrade somewhere or an input data specific issue we just haven't run into yet?

@snowman2
Copy link
Member Author

snowman2 commented Jan 16, 2024

Is this something we're seeing now due to a version upgrade somewhere or an input data specific issue we just haven't run into yet?

Yes, that is correct. We hadn't tried rasterizing the Int*DType from pandas before. This issue popped up recently.

@snowman2 snowman2 merged commit 341b730 into master Jan 16, 2024
14 of 15 checks passed
@snowman2 snowman2 deleted the integer_array branch January 16, 2024 20:43
@snowman2
Copy link
Member Author

Thanks @alfredoahds 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants