Update encounter_but_green for https://github.com/corona-warn-app/cwa… #319

MarlisFriedl · 2020-08-26T08:06:09Z

…-website/issues/307

src/data/faq_de.json

OlMue · 2020-09-01T09:35:10Z

@tkowark @MarlisFriedl #343 was requested by the RKI today and probably will be merged earlier than this pull request. This might lead to a conflict, but can be resolved later when you're ready.

mtb77 · 2020-09-01T11:11:31Z

Hi @OlMue, @MarlisFriedl is not responsible for the FAQs anymore, @svengabr and me are now in charge.
Should we have a look at the conflicts?

Cheers,
Sascha

daimpi · 2020-09-01T11:24:07Z

@mtb77 could you please revert #343 until we have clarification on this issue? B/c it currently introduces factually incorrect information into the FAQ: #307 (comment)

mtb77 · 2020-09-01T11:43:06Z

@daimpi let me clarify that first

mtb77 · 2020-09-01T12:46:16Z

@daimpi Just had a call with Oliver. I will need to get back with both pull requests to @janetback and the RKI and will give you feedback shortly. Until then we will keep the PR merged.

Cheers,
Sascha

daimpi · 2020-09-01T14:09:26Z

@mtb77
While I'm not particularly happy with leaving a PR that introduces factually wrong information into the live FAQ lingering, it will probably not cause too much problems if we can get this sorted out quickly.

Thanks for your effort 👍 🙂.

daimpi · 2020-09-05T13:37:23Z

@mtb77 any update on how you plan to proceed with this issue?

mtb77 · 2020-09-06T21:27:51Z

@daimpi hi I will give you an update on this issue tomorrow - sorry for the delay!

Cheers,
Sascha

mtb77 · 2020-09-08T12:20:28Z

@daimpi i merged master back into this branch - can you please doublecheck if i missed a change?

* master: Format filenames as monospace Fix typos Capitalise language names 2020-09-04-cwa-1-3-post (#344) Update faq.json Update faq_de.json # Conflicts: # src/data/faq.json # src/data/faq_de.json

* master: #349 adding new iOS13.7 path to documentation

* master: added faq entry for ene

daimpi · 2020-09-08T16:25:35Z

src/data/faq.json

-                            "The remaining encounters are rated collectively according to their distance and duration as well as the presumed infectiousness of the other person(s). This rating doesn't always yield an increased risk. This is why the Corona-Warn-App can display encounters, but the risk status stays the same.", "For more details about risk assessment, including a sample calculation, see <a href='https://github.com/corona-warn-app/cwa-documentation/blob/master/cwa-risk-assessment.md' target='_blank' rel='noopener noreferrer'>https://github.com/corona-warn-app/cwa-documentation/blob/master/cwa-risk-assessment.md</a>."
+                            "All active Corona-Warn-Apps regularly download the diagnosis keys released on the Corona-Warn-App server and pass them on to the operating system in batches through an interface. The app checks whether any of these received, recorded rolling proximity identifiers match any of the diagnosis keys. If there is a match, this means the following: The user’s smartphone encountered the smartphone of a person who has uploaded a diagnosis key on the day to which the diagnosis key belongs.",
+                            "In the next step, the app analyzes all the matching rolling proximity identifiers for each diagnosis key, to estimate how long the exposure lasted in total on the day in question and how close the smartphones were to each other on average during the exposure. The distance is calculated from the measured reduction in strength of the Bluetooth signal, which is specified in dB (decibel). All exposures for a diagnosis key that lasted less than 10 minutes in total (regardless of how close the smartphones came during that time) or during which the smartphones were more than 8 meters (73 dB attenuation) apart on average (regardless of how long the exposure lasted) are rated as harmless. This is why the Corona-Warn-App can display encounters, but the risk status stays the same.",
+                            "The remaining encounters are rated collectively according to their distance and duration as well as the presumed infectiousness of the other person(s). This rating doesn't always yield an increased risk. This is why the Corona-Warn-App can display encounters, but the risk status stays the same.", 


Nice!
This change accurately describes the two ways how green encounters can happen 👍.

One thing I was wondering about, but unfortunately don't have a solution: The new entry now states twice in short succession

This is why the Corona-Warn-App can display encounters, but the risk status stays the same.

While this is o/c all correct, I was wondering whether we could formulate this a bit smoother, but I unfortunately don't have a suggestion right now. But it's also not really important, just some cosmetics. What do you think? 🙂

daimpi · 2020-09-08T16:33:37Z

src/data/faq_de.json

-                            "Alle aktiven Corona-Warn-Apps laden regelmäßig die veröffentlichten Positivkennungen vom Corona-Warn-App-Server herunter und übergeben sie gesammelt über eine Schnittstelle an das Betriebssystem. Dort wird geprüft, ob empfangene und aufgezeichnete Zufallscodes vorliegen, die zu einer der Positivkennungen passen. Passen sie zusammen, heißt das Folgendes: Ihr Smartphone, das die Zufallscodes aufgezeichnet hat, und das Smartphone der Corona-positiv getesteten Person, die die Positivkennung hochgeladen hat, sind sich an einem der letzten 14 Tagen begegnet.",
-                            "Als nächstes wird für jede Positivkennung anhand aller dazu passenden Zufallscodes geschätzt, wie lange die Begegnungen jenes Tags insgesamt gedauert haben und wie nahe die Smartphones sich dabei im Durchschnitt waren. Die Entfernung wird aus der gemessenen Abschwächung des Bluetooth-Signals errechnet, die in dB (Dezibel) angegeben wird. Jedem dB-Wert lässt sich eine Entfernung im Freiraum (d.h. ohne Hindernisse im Signalweg) zuordnen. Alle Begegnungen zu einer Positivkennung, die insgesamt weniger als 10 Minuten gedauert haben (egal, wie nahe sich die Smartphones dabei gekommen sind) oder bei denen die Smartphones im Durchschnitt mehr als ca. 8 Meter Freiraum (73 dB Dämpfung) voneinander entfernt waren (egal, wie lange sie insgesamt gedauert haben), werden als unbedenklich verworfen.",
+                            "Alle aktiven Corona-Warn-Apps laden regelmäßig die veröffentlichten Positivkennungen vom Corona-Warn-App-Server herunter und übergeben sie gesammelt über eine Schnittstelle an das Betriebssystem. Dort wird geprüft, ob empfangene und aufgezeichnete Zufallscodes vorliegen, die zu einer der Positivkennungen passen. Passen sie zusammen, heißt das Folgendes: Ihr Smartphone, das die Zufallscodes aufgezeichnet hat, und das Smartphone der Corona-positiv getesteten Person, die die Positivkennung hochgeladen hat, sind sich am angegebenen Tag begegnet.",
+                            "Als nächstes wird für jede Positivkennung anhand aller dazu passenden Zufallscodes geschätzt, wie lange die Begegnungen jenes Tags insgesamt gedauert haben und wie nahe die Smartphones sich dabei im Durchschnitt waren. Die Entfernung wird aus der gemessenen Abschwächung des Bluetooth-Signals errechnet, die in dB (Dezibel) angegeben wird. Jedem dB-Wert lässt sich eine Entfernung im Freiraum (d.h. ohne Hindernisse im Signalweg) zuordnen. Alle Begegnungen zu einer Positivkennung, die insgesamt weniger als 10 Minuten gedauert haben (egal, wie nahe sich die Smartphones dabei gekommen sind) oder bei denen die Smartphones im Durchschnitt mehr als ca. 8 Meter Freiraum (73 dB Dämpfung) voneinander entfernt waren (egal, wie lange sie insgesamt gedauert haben), werden als unbedenklich bewertet. Deswegen kann die Corona-Warn-App Ihnen Begegnungen anzeigen, ohne dass die Risikobewertung sich ändert.",
                            "Die verbleibenden Begegnungen werden in ihrer Gesamtheit unter Berücksichtigung ihres Abstands und ihrer Dauer sowie der vermutlichen Infektiosität der anderen Person(en) bewertet. Nicht immer ergibt diese Bewertung ein erhöhtes Risiko. Deswegen kann die Corona-Warn-App Ihnen Begegnungen gemeldet haben, ohne dass die Risikobewertung sich ändert.",


the English version states:

This is why the Corona-Warn-App can display encounters, but the risk status stays the same.

while the German one says:

Deswegen kann die Corona-Warn-App Ihnen Begegnungen gemeldet haben, ohne dass die Risikobewertung sich ändert.

display encounters != Begegnung gemeldet

maybe the German version could be brought in line with the English one? Something like "Deswegen kann die Corona-Warn-App Ihnen Begegnungen anzeigen, […]"?

If you compare this (line 63) with the textblock above in line 62, there it has already been adjusted :).
It's not that important, just thought I'd mention it 🙂

daimpi · 2020-09-08T18:24:59Z

@mtb77 looks good to me, thanks 👍.

I've left two small remarks in the diff, but nothing important.
So imho this can also just be merged as is 🙂.

daimpi · 2020-09-10T10:09:00Z

src/data/faq.json

@@ -59,7 +59,7 @@
                        "active": true,
                        "textblock": [
                            "All active Corona-Warn-Apps regularly download the diagnosis keys released on the Corona-Warn-App server and pass them on to the operating system in batches through an interface. The app checks whether any of these received, recorded rolling proximity identifiers match any of the diagnosis keys. If there is a match, this means the following: The user’s smartphone encountered the smartphone of a person who has uploaded a diagnosis key on the day to which the diagnosis key belongs.",
-                            "In the next step, the app analyzes all the matching rolling proximity identifiers for each diagnosis key, to estimate how long the exposure lasted in total on the day in question and how close the smartphones were to each other on average during the exposure. The distance is calculated from the measured reduction in strength of the Bluetooth signal, which is specified in dB (decibel). All exposures for a diagnosis key that lasted less than 10 minutes in total (regardless of how close the smartphones came during that time) or during which the smartphones were more than 8 meters (73 dB attenuation) apart on average (regardless of how long the exposure lasted) are rated as harmless. This is why the Corona-Warn-App can display encounters, but the risk status stays the same.",
+                            "In the next step, the app analyzes all the matching rolling proximity identifiers for each diagnosis key, to estimate how long the exposure lasted in total on the day in question and how close the smartphones were to each other on average during the exposure. The distance is calculated from the measured reduction in strength of the Bluetooth signal, which is specified in dB (decibel). All exposures for a diagnosis key that lasted less than 10 minutes in total (regardless of how close the smartphones came during that time) or during which the smartphones were more than 8 meters (73 dB attenuation) apart on average (regardless of how long the exposure lasted) are rated as harmless.",


The new formulation does indeed fix the repetition, but unfortunately introduces ambiguity whether those "very low risk encounters" (<10min or >73 dB) are shown as "green-/low risk" encounters (which they are). If you're interested I can try to come up with a formulation which unites both aspects later today 🙂

I was struggling with the build :) yes please!

Update encounter_but_green for #307

d3db1f9

MarlisFriedl requested review from SebastianWolf-SAP and tkowark as code owners August 26, 2020 08:06

Update encounter_but_green for github issue 307

fda59e9

#307

tkowark mentioned this pull request Aug 26, 2020

Correct FAQ entry for green/low risk encounters #307

Closed

daimpi reviewed Aug 26, 2020

View reviewed changes

src/data/faq_de.json Outdated Show resolved Hide resolved

tkowark added 4 commits August 26, 2020 17:43

Merge branch 'master' into MarlisFriedl-patch-b

782bc78

JSON Formatting and final remarks

9c4c513

Merge branch 'master' into MarlisFriedl-patch-b

dbfd914

Merge branch 'master' into MarlisFriedl-patch-b

6572b84

tkowark added the To Be Reviewed Issue which needs to be discussed internally with the development team. label Aug 28, 2020

Merge branch 'master' into MarlisFriedl-patch-b

409d45c

OlMue mentioned this pull request Sep 1, 2020

Updated encounter but green #343

Merged

Ein-Tim mentioned this pull request Sep 5, 2020

"COVID-19 Exposure Logging - Weekly Update" - Strange information corona-warn-app/cwa-app-ios#1096

Closed

Merged Master

2618be1

mtb77 added 3 commits September 8, 2020 14:26

Merge branch 'master' into MarlisFriedl-patch-b

47a021c

* master: Format filenames as monospace Fix typos Capitalise language names 2020-09-04-cwa-1-3-post (#344) Update faq.json Update faq_de.json # Conflicts: # src/data/faq.json # src/data/faq_de.json

Missed change in PR

f5e2c7c

Merge branch 'master' into MarlisFriedl-patch-b

d7a356d

* master: #349 adding new iOS13.7 path to documentation

mtb77 requested review from mtb77 and removed request for tkowark and SebastianWolf-SAP September 8, 2020 12:33

Merge branch 'master' into MarlisFriedl-patch-b

aece910

* master: added faq entry for ene

daimpi reviewed Sep 8, 2020

View reviewed changes

mtb77 approved these changes Sep 10, 2020

View reviewed changes

mtb77 added 3 commits September 10, 2020 11:23

Removed duplicate sentence

0531070

Upd Build Chrome

b0860a6

Upd modification date

67bef14

daimpi reviewed Sep 10, 2020

View reviewed changes

Cross Origin Error in Build

297919b

mtb77 merged commit fac9835 into master Sep 10, 2020

mtb77 deleted the MarlisFriedl-patch-b branch September 10, 2020 11:57

daimpi mentioned this pull request Sep 12, 2020

Enhance FAQ entry for green/low risk encounters #365

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update encounter_but_green for https://github.com/corona-warn-app/cwa… #319

Update encounter_but_green for https://github.com/corona-warn-app/cwa… #319

MarlisFriedl commented Aug 26, 2020

OlMue commented Sep 1, 2020

mtb77 commented Sep 1, 2020

daimpi commented Sep 1, 2020

mtb77 commented Sep 1, 2020

mtb77 commented Sep 1, 2020

daimpi commented Sep 1, 2020

daimpi commented Sep 5, 2020

mtb77 commented Sep 6, 2020

mtb77 commented Sep 8, 2020

daimpi Sep 8, 2020

daimpi Sep 8, 2020

daimpi commented Sep 8, 2020

daimpi Sep 10, 2020

mtb77 Sep 10, 2020

Update encounter_but_green for https://github.com/corona-warn-app/cwa… #319

Update encounter_but_green for https://github.com/corona-warn-app/cwa… #319

Conversation

MarlisFriedl commented Aug 26, 2020

OlMue commented Sep 1, 2020

mtb77 commented Sep 1, 2020

daimpi commented Sep 1, 2020

mtb77 commented Sep 1, 2020

mtb77 commented Sep 1, 2020

daimpi commented Sep 1, 2020

daimpi commented Sep 5, 2020

mtb77 commented Sep 6, 2020

mtb77 commented Sep 8, 2020

daimpi Sep 8, 2020

Choose a reason for hiding this comment

daimpi Sep 8, 2020

Choose a reason for hiding this comment

daimpi commented Sep 8, 2020

daimpi Sep 10, 2020

Choose a reason for hiding this comment

mtb77 Sep 10, 2020

Choose a reason for hiding this comment