This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded to one or more specific destination folder
…nto iak/destinations
nritholtz
suggested changes
Feb 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some typo fixes and minor suggestions on reworking the implementation.
Co-authored-by: Nathaniel Ritholtz <[email protected]>
Co-authored-by: Nathaniel Ritholtz <[email protected]>
nritholtz
suggested changes
Feb 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work! two very minor fixes, otherwise looks good to me
Co-authored-by: Nathaniel Ritholtz <[email protected]>
Hi @nritholtz , Sorry for off topic, but as we discussed inside our team, the tool is missing |
nritholtz
approved these changes
Feb 15, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature enables module management with specific destinations, while back compatibility is intact.
Centrally managed:
Terrafile
is located in "root" directory of your terraform code, managing modules in all subfolders / stacksAn example of using
Terrafile
in a root directory:Let's assume following directory structure structure
In above scenarion Terrafile is not in every single folder but in the "root" of terraform code.
An example usage of centrally managed modules:
The
destination
of module is an array of directories (stacks) where the module should be used.The module itself is fetched once and copied over to designated destionations.
Final destination of the module is handled in a similar way as in first approach:
$destination/$module_path/$module_key
.The output of the run is exactly the same in both options.