Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Clean flag added #14

Merged
merged 28 commits into from
Feb 16, 2023
Merged

Clean flag added #14

merged 28 commits into from
Feb 16, 2023

Conversation

ivan-kostko
Copy link
Contributor

Introduced flag -c or --clean in order to remove all contents of destinations and module path upon fetching artefacts. As flag defaults to false -back compatibility stays intact.

ivan-kostko and others added 24 commits January 19, 2023 20:50
@ivan-kostko
Added destination option to configuration, so each module could be ad…
b697a5d 
…ded to one or more specific destination folder
@ivan-kostko
Adjusted tests, so they are extended, not changed
0c7e7c8
@ivan-kostko
Copy clonned modules concurrently
48af9b2
@ivan-kostko
Explicitly passing parameters to routines
cf89a45
@ivan-kostko
Destination is appended with ModulePath
573b79a
@mr00wka
updates readme, initially fetches module to temp dir
b7f4cda
@ivan-kostko
Clean-up destinations upon distributing version
a13397b
@ivan-kostko
Cleanup and fixed firstDestination
c753483
@ivan-kostko
Refactored dependency to deprecated ioutil -> os
4ee1013
@ivan-kostko
Remove test artifacts upon re-run
95367a6
@mr00wka
updates readme file
ec032e1
@ivan-kostko
Tests adjusted to represent documentation case
28ec4f6
@ivan-kostko
Merge branch 'iak/destinations' of github.com:ivan-kostko/terrafile i…
1582e7e 
…nto iak/destinations
@ivan-kostko
Better log output fro cleanup
a961af9
@ivan-kostko
Removed dev environment
fcccbd0
@ivan-kostko @nritholtz
Apply suggestions from code review fixing typos
2d99974 
Co-authored-by: Nathaniel Ritholtz <[email protected]>
@ivan-kostko
CR Fixes
b5dfbf0 
* Destination -> Destinations

* SymLink instead of copy. Hardlinks won't work for directories

* Adjusted tests to fixes
@ivan-kostko @nritholtz
Apply suggestions from code review to documentation
bc012e5 
Co-authored-by: Nathaniel Ritholtz <[email protected]>
@ivan-kostko @nritholtz
Apply suggestions from code review fixing typos
b7302fc 
Co-authored-by: Nathaniel Ritholtz <[email protected]>
@ivan-kostko
Implemention of Clean flag
5e35d78
@ivan-kostko
Bumped dependencies versions
c1b35db 
* testify v1.2.2 -> v1.8.1

* gopkg.in/yaml.v3 v3.0.1  indirect
@ivan-kostko
Tests for Clean flag
faf6dc4
@ivan-kostko
Vendor packages update
59d3fa4
@ivan-kostko
Vendor packages update
1b135c8
@ivan-kostko ivan-kostko marked this pull request as draft February 15, 2023 17:05
@ivan-kostko ivan-kostko marked this pull request as ready for review February 15, 2023 17:20
@ivan-kostko ivan-kostko marked this pull request as draft February 15, 2023 17:31
@ivan-kostko ivan-kostko marked this pull request as ready for review February 15, 2023 17:42
nritholtz
nritholtz suggested changes Feb 15, 2023
View reviewed changes
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
ivan-kostko and others added 2 commits February 16, 2023 08:59
@ivan-kostko @nritholtz
Apply suggestions from code review
ed66d1c 
Co-authored-by: Nathaniel Ritholtz <[email protected]>
@ivan-kostko
CR suggestions:
a8f43cd 
* added warning to clean flag

* combined together getUnigueDestinations with cleanDestinations into single function cleanDestinations
nritholtz
nritholtz approved these changes Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@nritholtz nritholtz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I have released a new version of terrafile with your two PRs. Thanks!

@nritholtz nritholtz merged commit 080cfbb into coretech:master Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nritholtz nritholtz nritholtz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivan-kostko @nritholtz @mr00wka