Consider moving ignition-firstboot-complete.service to fedora-coreos-config #1125
Assignees
Labels
jira
for syncing to jira
Comments
|
Makes sense to me. |
|
Notably: we would also need to re-run zipl on s390x inside the initrd. |
jlebon
added a commit
to jlebon/fedora-coreos-config
that referenced
this issue
Jul 6, 2021
This is mostly a mechanical move of ignition-firstboot-complete.service to this repo. The only differences are tweaking the service unit name and the Description and Documentation keys. Prompted by tweaks we'd like to do here, and possibly eventually moving it to the initramfs fully (merging it with coreos-boot-edit.service). For background, see: coreos/ignition#1125
jlebon
added a commit
to jlebon/ignition
that referenced
this issue
Jul 6, 2021
This is a distro-level integration service. Let's remove it from here and have it live e.g. in coreos/fedora-coreos-config for FCOS/RHCOS. Closes: coreos#1125
jlebon
added a commit
to jlebon/fedora-coreos-config
that referenced
this issue
Jul 6, 2021
This is mostly a mechanical move of ignition-firstboot-complete.service to this repo. The only differences are tweaking the service unit name and the Description and Documentation keys. Prompted by tweaks we'd like to do here, and possibly eventually moving it to the initramfs fully (merging it with coreos-boot-edit.service). The renaming also allows us to loosen the order of operation in which this is done, so that we can get this in to enable the new unit, while keeping the old unit disabled, without necessarily waiting for the original unit file itself to drop out of the `ignition` package. For background, see: coreos/ignition#1125
jlebon
added a commit
to coreos/fedora-coreos-config
that referenced
this issue
Jul 7, 2021
This is mostly a mechanical move of ignition-firstboot-complete.service to this repo. The only differences are tweaking the service unit name and the Description and Documentation keys. Prompted by tweaks we'd like to do here, and possibly eventually moving it to the initramfs fully (merging it with coreos-boot-edit.service). The renaming also allows us to loosen the order of operation in which this is done, so that we can get this in to enable the new unit, while keeping the old unit disabled, without necessarily waiting for the original unit file itself to drop out of the `ignition` package. For background, see: coreos/ignition#1125
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this issue
Oct 10, 2023
This is mostly a mechanical move of ignition-firstboot-complete.service to this repo. The only differences are tweaking the service unit name and the Description and Documentation keys. Prompted by tweaks we'd like to do here, and possibly eventually moving it to the initramfs fully (merging it with coreos-boot-edit.service). The renaming also allows us to loosen the order of operation in which this is done, so that we can get this in to enable the new unit, while keeping the old unit disabled, without necessarily waiting for the original unit file itself to drop out of the `ignition` package. For background, see: coreos/ignition#1125
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this issue
Oct 10, 2023
This is mostly a mechanical move of ignition-firstboot-complete.service to this repo. The only differences are tweaking the service unit name and the Description and Documentation keys. Prompted by tweaks we'd like to do here, and possibly eventually moving it to the initramfs fully (merging it with coreos-boot-edit.service). The renaming also allows us to loosen the order of operation in which this is done, so that we can get this in to enable the new unit, while keeping the old unit disabled, without necessarily waiting for the original unit file itself to drop out of the `ignition` package. For background, see: coreos/ignition#1125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Moved from discussions in #1124.
Right now, Ignition ships the service unit which deletes the
ignition.firstbootstamp file:https://github.com/coreos/ignition/blob/master/systemd/ignition-firstboot-complete.service
I'd like to propose moving that logic to fedora-coreos-config because the wiring for
/boot/ignition.firstboot-->ignition.firstbootkarg is a distro-specific thing (i.e. for FCOS, it's implemented by https://github.com/coreos/coreos-assembler/blob/d16e8df7b93a911a657f3e3eb989a75f084d6e25/src/create_disk.sh#L405 and https://github.com/coreos/coreos-assembler/blob/d16e8df7b93a911a657f3e3eb989a75f084d6e25/src/grub.cfg#L46-L57). So it seems cleaner to me to have the corresponding stamp removal also live on the distro side.If we don't do this, then we should make it clear that Ignition expects from the distro that the
ignition.firstbootkarg is implemented via a stamp file at/boot/ignition.firstboot(which IMO seems highly prescriptive).The text was updated successfully, but these errors were encountered: