-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
05core: add coreos-ignition-firstboot-complete.service #1087
Conversation
This is mostly a mechanical move of ignition-firstboot-complete.service to this repo. The only differences are tweaking the service unit name and the Description and Documentation keys. Prompted by tweaks we'd like to do here, and possibly eventually moving it to the initramfs fully (merging it with coreos-boot-edit.service). The renaming also allows us to loosen the order of operation in which this is done, so that we can get this in to enable the new unit, while keeping the old unit disabled, without necessarily waiting for the original unit file itself to drop out of the `ignition` package. For background, see: coreos/ignition#1125
Ignition side of this at coreos/ignition#1245. Tested successfully:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Although this is pretty straightforward, it's also a fundamental piece of the Ignition integration. So let's hold this until releases next week to be safe. |
@bgilbert convinced me we should do this now so that we can ship a fix for coreos/fedora-coreos-tracker#889 (comment) in the next set of releases. |
This is mostly a mechanical move of ignition-firstboot-complete.service
to this repo. The only differences are tweaking the service unit name
and the Description and Documentation keys.
Prompted by tweaks we'd like to do here, and possibly eventually moving
it to the initramfs fully (merging it with coreos-boot-edit.service).
The renaming also allows us to loosen the order of operation in which
this is done, so that we can get this in to enable the new unit, while
keeping the old unit disabled, without necessarily waiting for the
original unit file itself to drop out of the
ignition
package.For background, see: coreos/ignition#1125