Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings from golangci-lint #1121

Closed
bgilbert opened this issue Oct 29, 2020 · 3 comments · Fixed by #1149
Closed

Fix warnings from golangci-lint #1121

bgilbert opened this issue Oct 29, 2020 · 3 comments · Fixed by #1149
Assignees
@sohankunkerkar
Labels
area/stability jira for syncing to jira kind/cleanup low hanging fruit

Comments

@bgilbert
Copy link
Contributor

We should run golangci-lint over the Ignition codebase. See coreos/coreos-assembler#1813 for example output from Mantle. @darkmuggle reports that the Ignition summary results are:

     50 (errcheck)
      9 (staticcheck)
      9 (gosimple)
      4 (deadcode)
      1 (unused)
      1 (structcheck)
      1 (ineffassign)
@arithx
Copy link
Contributor

arithx commented Oct 29, 2020

If we're going to implement golangci-lint we should definitely add it to the CI jobs that run as well 😄

@bgilbert bgilbert added low hanging fruit jira for syncing to jira labels Oct 29, 2020
@sohankunkerkar sohankunkerkar self-assigned this Oct 29, 2020
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Oct 29, 2020
@sohankunkerkar
Makefile: add make lint
41ce93c 
Address coreos#1121
This change will run golangci-lint over the Ignition codebase and
check for any liniting issues.
@darkmuggle darkmuggle mentioned this issue Oct 29, 2020
Merged
@jlebon
Copy link
Member

jlebon commented Oct 29, 2020

Should we have a similar issue for fcct?

@bgilbert
Copy link
Contributor Author

Sure, filed as coreos/butane#149.

sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Dec 7, 2020
@sohankunkerkar
*: fix staticcheck warnings
79d6d7e 
Fixes part of coreos#1121
@sohankunkerkar sohankunkerkar mentioned this issue Dec 7, 2020
Merged
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Dec 7, 2020
@sohankunkerkar
*: fix staticcheck warnings
dffafdd 
Fixes part of coreos#1121
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Dec 7, 2020
@sohankunkerkar
*: fix staticcheck warnings
14f1ee5 
Fixes part of coreos#1121
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Dec 7, 2020
@sohankunkerkar
*: fix staticcheck warnings
35ad417 
Fixes part of coreos#1121
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Dec 7, 2020
@sohankunkerkar
*: fix staticcheck warnings
a47976a 
Fixes part of coreos#1121
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Dec 7, 2020
@sohankunkerkar
*: fix staticcheck warnings
f0d9232 
Fixes part of coreos#1121
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Dec 7, 2020
@sohankunkerkar
*: fix staticcheck warnings
d2729d6 
Fixes part of coreos#1121
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Dec 7, 2020
@sohankunkerkar
*: fix staticcheck warnings
4fa454c 
Fixes part of coreos#1121
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Dec 7, 2020
@sohankunkerkar
*: fix deadcode warnings
65d3697 
Fixes part of coreos#1121
@sohankunkerkar sohankunkerkar mentioned this issue Dec 7, 2020
Merged
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Dec 7, 2020
@sohankunkerkar
*: fix gosimple warnings
548c250 
Fixes part of coreos#1121
@sohankunkerkar sohankunkerkar mentioned this issue Dec 7, 2020
Merged
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Dec 8, 2020
@sohankunkerkar
*: fix errcheck warnings
50ba928 
Fixes part of coreos#1121
@sohankunkerkar sohankunkerkar mentioned this issue Dec 8, 2020
Merged
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Dec 8, 2020
@sohankunkerkar
*: silence errcheck warnings
9004e2c 
Fixes part of coreos#1121
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Dec 10, 2020
@sohankunkerkar
*: fix errcheck warnings
b1dff9e 
Fixes part of coreos#1121
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Dec 10, 2020
@sohankunkerkar
*: fix errcheck warnings
fd5d68e 
Fixes part of coreos#1121
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Dec 10, 2020
@sohankunkerkar
*: fix errcheck warnings
661bf94 
Fixes part of coreos#1121
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Dec 11, 2020
@sohankunkerkar
internal/log: drop the error return to appease golanci-lint
7395895 
Fixes part of coreos#1121
sohankunkerkar added a commit to sohankunkerkar/ignition that referenced this issue Dec 11, 2020
@sohankunkerkar
internal/log: drop the error return to appease golanci-lint
9963678 
Fixes part of coreos#1121
@sohankunkerkar sohankunkerkar linked a pull request Dec 15, 2020 that will close this issue
*: fix golangci-lint warnings #1149
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sohankunkerkar sohankunkerkar

Labels
area/stability jira for syncing to jira kind/cleanup low hanging fruit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: fix golangci-lint warnings sohankunkerkar/ignition
4 participants
@bgilbert @arithx @jlebon @sohankunkerkar