Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings from golangci-lint #149

Closed
bgilbert opened this issue Oct 29, 2020 · 2 comments · Fixed by #200
Closed

Fix warnings from golangci-lint #149

bgilbert opened this issue Oct 29, 2020 · 2 comments · Fixed by #200
Labels
enhancement New feature or request good first issue Good for newcomers jira

Comments

@bgilbert
Copy link
Contributor

We should run golangci-lint over the FCCT codebase and then run it from CI. See coreos/coreos-assembler#1813 for example output from Mantle.
@bgilbert bgilbert added enhancement New feature or request jira labels Oct 29, 2020
@bgilbert bgilbert mentioned this issue Oct 29, 2020
Closed
@nasirhm
Copy link

nasirhm commented Nov 24, 2020

Sure, I would like to work on it.

@bgilbert

@bgilbert
Copy link
Contributor Author

Sure, PRs welcome!

@sohankunkerkar sohankunkerkar added the good first issue Good for newcomers label Nov 24, 2020
@bgilbert bgilbert mentioned this issue Feb 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: run golangci-lint
3 participants
@bgilbert @sohankunkerkar @nasirhm