Add missing wifi firmware checks #2963
Conversation
There are multiple live image tricks that need documenting, so give them their own page.
Stop conflating them with install docs. Since live-booting-ipxe.adoc now contains PXE and ISO instructions as well, rename it to live-booting.adoc, update the nav title, and add a redirect.
Get rid of the manual configuration cruft. De-emphasize the distinction between live and dest Ignition configs, since users won't have to care about that as much. Fixes coreos/fedora-coreos-docs#245.
In particular, --copy-network isn't limited to the ISO/PXE environment, but also works when running coreos-installer directly on bare metal.
Issue: coreos/fedora-coreos-docs#353 Co-authored-by: Dusty Mabe <[email protected]> Signed-off-by: Nikita Dubrovskii <[email protected]>
This one example doesn't set with_mount_unit, so the resulting filesystem won't be mounted by default. Fix this.
RHEL 8 ships a different implementation of mkpasswd that doesn't support modern hashes. For ease of use, just containerize mkpasswd. Fixes coreos/fedora-coreos-docs#322.
Fixes: ``` $ ./build.sh This build script is using Podman to run the build in an isolated environment. antora: option '--html-url-extension-style <choice>' argument 'indexify site.yml' is invalid. Allowed choices are default, drop, indexify. ``` See https://pagure.io/fedora-docs/template/pull-request/21
Add new page to store documentation for major changes happening in Fedora CoreOS.
I think the intention here was to use `#!/bin/sh` but I don't think this line is required so let's just delete it.
Triggered by update-versions GitHub Action.
This is supported as of coreos#1526 and allows us to recommend rootfs_url even without an HTTP(S) server.
Triggered by update-versions GitHub Action.
This should fix the substitution on the Fedora built & hosted version of the docs.
Move the "automatically modified" comment, update the commit message, and regenerate antora.yml. Fixes: 87f7f6c ("Move asciidoc attributes to antora.yml")
Triggered by update-versions GitHub Action.
- add note about vultr-cli and s3cmd being in the Fedora repos
- update s3cmd docs URL
- use long options for `--acl-public` for s3cmd
- update the used plan in the example
- the old example plan is no longer valid
- drop the note about the Vultr firewall
- I was able to SSH in with no Firewall groups
- Add a note about how to get the IP address of your instance
- IBM Cloud now has a fedora-coreos-stable-amd64 OS type - `--image-id` is deprecated in favor of `--image` - `--key-ids` is deprecated in favor of `--keys`
Users may want to modify the OVA to run on older versions of VMware products, so provide a simple example. Co-authored-by: Benjamin Gilbert <[email protected]>
`doctl compute image create` doesn't actually support `--wait`. This reverts commit 993137f.
overlay.d/15fcos/usr/lib/systemd/system/coreos-check-wireless-firmwares.service
Outdated
Show resolved
Hide resolved
overlay.d/15fcos/usr/lib/systemd/system/coreos-check-wireless-firmwares.service
Outdated
Show resolved
Hide resolved
overlay.d/15fcos/usr/lib/systemd/system/coreos-check-wireless-firmwares.service
Outdated
Show resolved
Hide resolved
jbtrystram
force-pushed
the
wifi-warning
branch
from
41c350b to
be97853
Compare
|
I guess the docs/faq needs to land first so we can make sure the link we are using is right. |
|
in CI: |
|
you'll need to use |
Some wifi-firmwares will be split into sub-packages in fedora 40 We will keep them in until fedora 41, but display a warning message in the console. This messages links to this FAQ entry. See coreos/fedora-coreos-config#2963 See coreos/fedora-coreos-tracker#1575
Some wifi-firmwares will be split into sub-packages in fedora 40 We will keep them in until fedora 41, but display a warning message in the console. This messages links to this FAQ entry. See coreos/fedora-coreos-config#2963 See coreos/fedora-coreos-tracker#1575
jbtrystram
force-pushed
the
wifi-warning
branch
from
be97853 to
5663347
Compare
Some wifi-firmwares will be split into sub-packages in fedora 40 We will keep them in until fedora 41, but display a warning message in the console. This messages links to this FAQ entry. See coreos/fedora-coreos-config#2963 See coreos/fedora-coreos-tracker#1575
Some wifi-firmwares will be split into sub-packages in fedora 40 We will keep them in until fedora 41, but display a warning message in the console. This messages links to this FAQ entry. See coreos#2963 See coreos/fedora-coreos-tracker#1575
| ########################################################################## | ||
| WARNING: The NetworkManager-wifi is a requested layered package on this | ||
| system, but no Wi-Fi drivers are requested. The Wi-Fi drivers will no | ||
| longer be included by default in the future. |
There was a problem hiding this comment.
Do we have a possible date/version for when this will no longer be available?
Should we warn the users about this deadline?
There was a problem hiding this comment.
good point. I think we agreed on removing the packages on F41.
| bcm283x-firmware | ||
| zd1211-firmware | ||
| ) | ||
| regex=$(IFS='|'; echo "${firmwares[*]}") |
There was a problem hiding this comment.
This is a little confusing, maybe a comment with an explanation of what this part of code does would be a nice to see.
There was a problem hiding this comment.
I think an explanation in the code would be a little bit clumsy, so i'll do it here :
IFS is Internal Field Separator in bash. The default value is "".
This is how the shell separates values.
e.g. in
fruits="apple pear orange"
for i in $fruits
do
echo "'$i' is a fruit"
done
This will loop over "apple", "pear" then "orange".
writing:
fruits="apple|pear|orange"
IFS='|'; for i in $fruits
do
echo "'$i' is a fruit"
done
Would have the same result.
So what IFS='|'; echo "${firmwares[*]} does is echoing all the values in firmwares but instead of the default in between, the output will be a|b|c|d, which is convenient because it means OR
There was a problem hiding this comment.
I was considering potential code review in the future, where it could take time for someone to understand this bit of code. It certainly took me a while - thank you for the explanation though!
There was a problem hiding this comment.
rather than document in a comment what IFS does we could explain what the outcome of the following statement would be, which I think would achieve the goal:
| regex=$(IFS='|'; echo "${firmwares[*]}") | |
| # Get firmware names into `a|b|c|d` regex string | |
| regex=$(IFS='|'; echo "${firmwares[*]}") |
Then if the reader wants to understand how IFS works they could go look it up, but they at least understand the goal of the current code.
There was a problem hiding this comment.
Oh yeah of course, i think i misunderstood Adam comment
Now we have a generic wifi enablement docs page and a FAQ entry that explains the specific situation we have now where the firwmare subpackages are getting dropped out of FCOS.
|
sorry I pushed up something here by mistake.. fixing |
|
opening |
|
I guess I no longer have permissions to push to that branch in his fork :( JB can you do a force push (or give me access to your fork and I can fix it). |
|
@dustymabe I re-enabled write access to maintainer on this branch, I am not sure why it got turned off |
Some wifi-firmwares will be split into sub-packages in fedora 40 We will keep them in until fedora 41, but display a warning message in the console. This messages links to this FAQ entry. See coreos/fedora-coreos-config#2963 See coreos/fedora-coreos-tracker#1575
|
@jbtrystram i'm still not able to push to it. and I can't re-open this PR because currently the branch in the fork doesn't share any history with this repo |
|
@dustymabe you pushed a branch from coreos/fedora-coreos-docs here. Sadly I realized that after I f***d my local repo trying to fix it. So i have no copies of the previous commit containing the MOTD script . |
|
Reflog to the rescue :) |
yeah it was a mistake on my part :(
I see below you found it, but yeah I had a local copy I was trying to push to fix but couldn't :( |
Some wifi-firmwares will be split into sub-packages in fedora 40 We will keep them in until fedora 41, but display a warning message in the console if NetworkManager-wifi is layered without the most popular the wifi firmwares.
See coreos/fedora-coreos-tracker#1575
This is an initial draft to get some discussion.
it's probably worth moving to a separate manifest and having it be a conditional include on
releasever < 41