35coreos-live: support coreos.live.rootfs_url=tftp://
#1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in coreos/fedora-coreos-tracker#1055, the rootfs_url karg is preferred over initrd concatenation due to its lower memory footprint and generally better performance. We originally chose to disallow its use with TFTP to reduce the feature matrix, but that forces users without HTTP servers to fall back to concatenation. Enable TFTP so rootfs_url can be used in all environments.
|
This will need a docs update. |
jlebon
approved these changes
Feb 23, 2022
|
Yup, it works! |
bgilbert
added a commit
to coreos/fedora-coreos-docs
that referenced
this pull request
Mar 16, 2022
This is supported as of coreos/fedora-coreos-config#1526 and allows us to recommend rootfs_url even without an HTTP(S) server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in coreos/fedora-coreos-tracker#1055, the
rootfs_urlkarg is preferred over initrd concatenation due to its lower memory footprint and generally better performance. We originally chose to disallow its use with TFTP to reduce the feature matrix, but that forces users without HTTP servers to fall back to concatenation. Enable TFTP sorootfs_urlcan be used in all environments.