Skip to content

Commit

Permalink
35coreos-live: support coreos.live.rootfs_url=tftp://
Browse files Browse the repository at this point in the history
As discussed in
coreos/fedora-coreos-tracker#1055, the
rootfs_url karg is preferred over initrd concatenation due to its lower
memory footprint and generally better performance.  We originally chose to
disallow its use with TFTP to reduce the feature matrix, but that forces
users without HTTP servers to fall back to concatenation.  Enable TFTP
so rootfs_url can be used in all environments.
bgilbert committed Feb 24, 2022
1 parent 4ae74aa commit 0a84651
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -23,12 +23,12 @@ elif [[ -n "${rootfs_url}" ]]; then
# rootfs URL was provided as karg. Fetch image, check its hash, and
# unpack it.
echo "Fetching rootfs image from ${rootfs_url}..."
if [[ ${rootfs_url} != http:* && ${rootfs_url} != https:* ]]; then
if [[ ${rootfs_url} != http:* && ${rootfs_url} != https:* && ${rootfs_url} != tftp:* ]]; then
# Don't commit to supporting protocols we might not want to expose in
# the long term.
echo "Unsupported scheme for image specified by:" >&2
echo "coreos.live.rootfs_url=${rootfs_url}" >&2
echo "Only HTTP and HTTPS are supported. Please fix your PXE configuration." >&2
echo "Only HTTP, HTTPS, and TFTP are supported. Please fix your PXE configuration." >&2
exit 1
fi

0 comments on commit 0a84651

Please sign in to comment.