buildextend-live: turn on osmet packing by default #1418
Conversation
|
This will fail until the new coreos-installer release with osmet support is in FCOS. /hold |
jlebon
force-pushed
the
pr/osmet-default
branch
from
5e8876c to
994b371
Compare
This is the final step in ratcheting osmet into place for offline installs by default. We drop the `--osmet` optional flag and now always perform osmet packing when generating the live ISO. (We could leave the switch around for a while just for compatibility, but meh... the only other place this exists right now is the coreos-installer CI, where we can trivially update it once this merges.) Though because RHCOS doesn't yet support osmet, we add support for an `osmet` knob in `image.yaml` which the RHCOS pipeline can use to turn it off for now. Closes: coreos/fedora-coreos-tracker#352
jlebon
changed the title
|
OK, I changed this now to also support an |
|
IIUC we want this for the round of releases we're doing tomorrow but we would want to go in and set osmet to false in the json for stable (because coreos-installer in the stable release won't support osmet). Is that right? |
This is now in FCOS coreos/fedora-coreos-config#381 |
🎉 /hold cancel
Yes, you're correct. Just going to make a note of this in coreos/fedora-coreos-streams#94 and coordinate with Sohan for when we promote the configs. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustymabe, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is the final step in ratcheting osmet into place for offline
installs by default. We drop the
--osmetoptional flag and now alwaysperform osmet packing when generating the live ISO.
(We could leave the switch around for a while just for compatibility,
but meh... the only other place this exists right now is the
coreos-installer CI, where we can trivially update it once this merges.)
Though because RHCOS doesn't yet support osmet, we add support for an
osmetknob inimage.yamlwhich the RHCOS pipeline can use to turn itoff for now.
Closes: coreos/fedora-coreos-tracker#352