Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release [email protected] #364

Closed
7 tasks done
hthetiot opened this issue Aug 13, 2019 · 7 comments
Closed
7 tasks done

Release [email protected] #364

hthetiot opened this issue Aug 13, 2019 · 7 comments
Assignees
Milestone

Comments

@hthetiot
Copy link
Contributor

hthetiot commented Aug 13, 2019

First will be testing cordova-plugin-iosrtc#master in order to release a stable [email protected], I will release first an [email protected] on NPM for testing.

Tasks

  • Rename GitHub organisation BasqueVoIPMafia to cordova-rtc in various location
  • Confirm new automatic hook is trigger and Swift 4.2 support on cordova add plugin using cordova 8+ and ionic 5+
  • Confirm iOS build on XCode 10.2+
  • Confirm Travis build is not false positive and use commit for version
  • Test basic WebRTC using a small sample app
  • Publish [email protected] on NPM via npm publish and set package.json version to 5.0.0`
  • Provide migration instruction for previous version

Testing procedure

ionic start cordovaPluginIosrtcSample blank; cd cordovaPluginIosrtcSample;
ionic cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc.git --verbose
cordova platform add ios
ionic cordova build ios --device -- --buildFlag="-UseModernBuildSystem=0"

@hthetiot
Copy link
Contributor Author

hthetiot commented Aug 14, 2019

@hthetiot hthetiot added this to the 5.0.0 milestone Aug 14, 2019
@hthetiot
Copy link
Contributor Author

hthetiot commented Aug 14, 2019

codova plugin install result in --production, meaning xcode need to be on dependencies not devDependencies.

Running command: npm install https://github.com/cordova-rtc/cordova-plugin-iosrtc.git#master --production --save

@cpgb85

This comment was marked as off-topic.

@hthetiot
Copy link
Contributor Author

hthetiot commented Aug 15, 2019

@cpgb85 it will be ready when it will be ready. I'm testing to be sure.
Dont ask again pls, and stop complaining (simplyrtc#8)

It's technically ready if you use following to install. (cordova 8+ required)

cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc.git#master --verbose

@hthetiot
Copy link
Contributor Author

hthetiot commented Aug 15, 2019

Added test script to test PluginMediaStreamRenderer features and local libwebrtc RTCPeerConnection.

Test Result on iOS 12.3.1 using iPhone 6:

BC18C72A-2327-4BF9-BF18-BF28AAB2B2F4

@hthetiot
Copy link
Contributor Author

@ibc @saghul I think I'm ready to publish, do you want to publish beta first?

@hthetiot
Copy link
Contributor Author

hthetiot commented Aug 15, 2019

Published on NPM https://www.npmjs.com/package/cordova-plugin-iosrtc

To upgrade/install

Cordova 8+ recommended

Pure cordova

cordova plugin remove cordova-plugin-iosrtc
cordova plugin add cordova-plugin-iosrtc@5 --verbose

remove hook file and hook call from config.xml

cordova platform remove ios
cordova platform add ios

With ionic

ionic cordova plugin remove cordova-plugin-iosrtc
ionic cordova plugin add cordova-plugin-iosrtc@5 --verbose

remove hook file and hook call from config.xml

ionic cordova platform remove ios
ionic cordova platform add ios

Expected log on platform add ios

Example from travis:

Example from local

Processing settings for platform: ios
--save flag or autosave detected
Saving ios@~4.5.5 into config.xml file ...
iosrtc-swift-support.js [INFO] ".pbxproj" project file found: /home/me/platforms/ios/myApp.xcodeproj/project.pbxproj
iosrtc-swift-support.js [INFO] ".xcconfig" project file found: /home/me/platforms/ios/cordova/build.xcconfig
iosrtc-swift-support.js [INFO] fixing issues in the generated project files:
iosrtc-swift-support.js [INFO] - "Runpath Search Paths" to: "@executable_path/Frameworks"
iosrtc-swift-support.js [INFO] - "Objective-C Bridging Header" to: "myApp/Plugins/cordova-plugin-iosrtc/cordova-plugin-iosrtc-Bridging-Header.h"
iosrtc-swift-support.js [INFO] - "ENABLE_BITCODE" set to: "NO"
iosrtc-swift-support.js [INFO] - "SWIFT_VERSION" set to: "4.2"
iosrtc-swift-support.js [INFO] file correctly fixed: /home/me/platforms/ios/cordova/build.xcconfig
iosrtc-swift-support.js [INFO] file correctly fixed: /home/me/platforms/ios/myApp.xcodeproj/project.pbxproj

Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants