Video renders in landscape, but not portrait orientation

[osnoww]

I am using the latest version of this plugin

If a video call is started in landscape mode, the call is successful on a variety of Apple phones and OS versions
if the call is started in portrait mode, the call fails. The console log contains error messages like
"failed to bind EAGLDrawable: <CAEAGLLayer: 0x60000271a480> to GL_RENDERBUFFER 1
Failed to make complete framebuffer object 8cd6"

[hthetiot]

I do not reproduce this issue.
Can you provide the iOS version used.

[hthetiot]

It may be related to the style of the video tag that you use in portrait causing the issue.
Can you share the CSS applied to the video tag you use in portrait? @osnoww

[hthetiot]

will test and confirm.

[hthetiot]

Can you try with latest v5.0.0 @osnoww see upgrade instructions here:

• Release [email protected] #364 (comment)

[hthetiot]

Cannot reproduce

[osnoww]

Hi Harold, we ended up rebuilding some of the legacy code in the cordova plugin to allow the latest webrtc lib to be used. Once we have cleaned it up and can document and build an example project, we will release back to open source. (This is several months away at least).

…

On Fri, 13 Sep 2019 at 17:43, Harold Thétiot ***@***.***> wrote: Closed #360 <#360>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#360?email_source=notifications&email_token=AIKPJ6CNB7AZXH4ZAT2ZOUDQJO7JVA5CNFSM4IGAAQFKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTTXWMKI#event-2632934953>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIKPJ6GTOFFIDYJ7HNQVKPTQJO7JVANCNFSM4IGAAQFA> .

[hthetiot]

Thank you @osnoww that a great news.
I hope you can make a PR, let me know if you want to give me a patch and do the cleaning for you.

Here is the initial draft and I have exposed RTCPeerConnection.addTrack|removeTrack already for the future migration in 5.0.2 next release.

• Task/update iosrtc webrtc patches  #366

PluginRTCPeerConnection.(addTrack|removeTrack) https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/task/getReceiversOrSenders-and-addOrRemoveTracks/src/PluginRTCPeerConnection.swift#L276

RTCPeerConnection_(addTrack|removeTrack):
https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/task/getReceiversOrSenders-and-addOrRemoveTracks/src/iosrtcPlugin.swift#L304

[cah-kyle-dunn]

I'm now experiencing this issue after iOS 13 (specifically, iOS 13.1.2). The attributes don't really change between orientations. It works in iOS 12.

[cah-kyle-dunn]

It appears to be fixed by #399

[hthetiot]

Yes @cah-dunn I can confirm on iOS #399 works fine, but the fact is I did not change anything regarding orientation detection beside calling Renderer every 500ms.

• https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/task/libwebrtc-update-m69/js/MediaStreamRenderer.js#L45

An alternative to it would be this:

window.addEventListener('resize', function () { 
    console.log('orientationChange');
    cordova.plugins.iosrtc.refreshVideos();

})

I'm not sure I will keep the Interval 500ms on release, you may want to check #master and confirm using resize event + cordova.plugins.iosrtc.refreshVideos does fix master.

[hthetiot]

May be this get trigger on #399 rotate but I have not check yet:

videoView(_ videoView: RTCEAGLVideoView!, didChangeVideoSize size: CGSize)
https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/master/src/PluginMediaStreamRenderer.swift

[hthetiot]

@osnoww check #399 it's M69 if you have above M75 please let me know I can take your change and integrate them may be.

[hthetiot]

Confirm "func videoView(_ videoView: RTCVideoRenderer, didChangeVideoSize size: CGSize) {" can call on orientation change on M69. cc @cah-dunn

[cah-kyle-dunn]

@hthetiot I did a good amount of debugging with master and I think it was likely an issue with the old libWebRTC-LATEST-Universal-Release.a and updating to WebRTC.framework fixed it. This specific issue actually caused issues in Safari after iOS 13 Beta 4 and had to be fixed in WebKit (https://bugs.webkit.org/show_bug.cgi?id=199519). Could be unrelated, but very coincidental.

I can confirm that the video view is being updated on orientation change. I think we could/should remove the 500ms interval prior to release.

Thanks for all of your work on this project by the way, you're making some awesome updates.

[hthetiot]

@cah-dunn Thank you for great feedback, much apreciated.

[osnoww]

Hi All, Since I raised this issue originally, I have worked with a Metal/iOS expert to fix the most serious issues with the webrtc Cordova plugin - the iOS component now uses Metal and the plugin is modified to allow the use of the current webrtc lib (the old plugin version had some hacks that I understand required older versions of webrtc. We aim to get the updated code pushed in the next couple of days.

…

On 9 Oct 2019, at 19:26, Harold Thétiot ***@***.***> wrote: @cah-dunn Thank you for great feedback, much apreciated. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[akilude]

@hthetiot the issue still persists when using the plugin (version 6.0).

Occurs when using the below css:
min-width: 100%; min-height: 100vh;

Simplest fix is to not specify min-width and min-height css.

I've tested on iOS 10, iphone XR

[hthetiot]

Do you call refreshVideos on rotate ?
Please provide full example, this issue has been close because I do not reproduce.

[hthetiot]

Note: this has nothing to do with Metal anyway.

[hthetiot]

Simplest fix is to not specify min-width and min-height css.

That not the same issue then @akilude
Here we talked about non rendering not issue with different CSS. READ issue please don't comment out of topic #360 (comment)

Please create separate issue with full example and will had support, alternatively don't do bad css like that use flexbox and with:100% height: 100%

[hthetiot]

See related function that get the size, should work with any proper CSS,...

https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/master/js/MediaStreamRenderer.js

Unless full example is provided, I will not reopen.