feat: Automatic Draft Release Creator; Reusable Workflow #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the test project
docs: updated doc to point out that step 2 is optional
`.github/release-drafter.yml` has been removed from this repo in favor of [this](https://github.com/coopnorge/.github/blob/main/.github/release-drafter.yml)
bendiknesbo
approved these changes
Oct 11, 2023
nhhagen
requested changes
Oct 11, 2023
There was a problem hiding this comment.
@arunpoudel this implementation should be moved to its own repository. The workflows in here should have been extracted into their own repos. This allows us to individually version workflows.
All our current workflows: https://github.com/orgs/coopnorge/repositories?q=github-workflow-&type=all&language=&sort=
See GitHub reusable workflows and actions for more information about setting up new reusable workflows.
arunpoudel
added a commit
to coopnorge/github-workflow-release-drafter
that referenced
this pull request
Oct 12, 2023
This implements automatic draft release creator reusable workflow. [See](coopnorge/engineering-github-actions#52) for more details.
|
Closing this PR as it has been moved here. |
arunpoudel
added a commit
to coopnorge/github-workflow-release-drafter
that referenced
this pull request
Oct 13, 2023
This implements automatic draft release creator reusable workflow. [See](coopnorge/engineering-github-actions#52) for more details. Resolves coopnorge/engineering-issues#325
arunpoudel
added a commit
to coopnorge/github-workflow-release-drafter
that referenced
this pull request
Oct 16, 2023
* feat: Automatic Draft Release Creator This implements automatic draft release creator reusable workflow. [See](coopnorge/engineering-github-actions#52) for more details. Resolves coopnorge/engineering-issues#325 * doc: added a para about how go release drafter works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
See
Changes
Features:
Docs:
Summary
This change introduces a new workflow that can be used to create automatic draft releases when a PR is created. Although it was originally only intended to be used by go, this can be used by other projects as well as is, if we do not introduce additional go related version enforcements into this workflow.
Reflection
As gorelease looked abandoned, I decided not to include it in this implementation.
For better suggestion on labels, we can also add (this)[https://github.com/bobg/modver] which will definitely solve(or maybe minimize, if not solve) our problem of reliance on github PR title and human action needed to correctly label PRs.
It has been intentionally designed and develop so that a human can always intervene and change the generation(be it labels or the draft PR). This is done so that we have some flexibility and control over versioning while still having helpers that will make works easier and faster.
Some other tools to investigate in future would be:
Resolves https://github.com/coopnorge/engineering-issues/issues/325