Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: beautified the changelog being generated #3

Closed
wants to merge 2 commits into from

Conversation

arunpoudel
Copy link
Contributor

@arunpoudel arunpoudel commented Oct 10, 2023

Added separate labels for version resolving and changelog generation.
This allows us to categorize changelogs.

Required by: coopnorge/engineering-github-actions#52

Added separate labels for version resolving and changelog generation.
This allows us to categorize changelogs.
title:
- "/^deprecate/i"
- label: "major"
- "/^Bump/" # Dependency update PR by depandabot
Copy link
Member

@misund misund Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependabot will prepend commit messages with chore(deps): if it looks like there are any recent semantic commits, will it not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can configure a prefix if we want

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look at commit message, but rather PR title, we can also search on PR body, branch name and files (glob only for file)

Copy link
Member

@misund misund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update so that commits with a scope will be recognized as well?

like type(scope): description
and not just type: description

Loving these changes btw.

Added support to scoped PR titles.

Eg: feat(scope): This is the description of the PR
@arunpoudel
Copy link
Contributor Author

@misund Changes has been made to accommodate scoped PR titles. Can you review? Thanks.

@arunpoudel
Copy link
Contributor Author

Decided to not have it in central repo, as it was getting difficult to make sure reusable-repos had proper access right to .github repo. Will abandon this idea for the time being. But might come back to this later.

@arunpoudel arunpoudel closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants