Merge pull request #24 from cooljeanius/autofix/alert-149-ca7fd9d43c

Fix code scanning alert NationalSecurityAgency#149: Multiplication result converted to larger type just a simple cast
cooljeanius · Sep 22, 2024 · f0eb0da · f0eb0da
2 parents 9e77536 + 46af5f1
commit f0eb0da
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/Ghidra/Features/Decompiler/src/decompile/cpp/constseq.cc b/Ghidra/Features/Decompiler/src/decompile/cpp/constseq.cc
@@ -142,7 +142,7 @@ int4 ArraySequence::formByteArray(int4 sz,int4 slot,uint8 rootOff,bool bigEndian
   if (count < MINIMUM_SEQUENCE_LENGTH)
     return 0;
   if (count != moveOps.size()) {
-    uint8 maxOff = rootOff + count * bigElSize;
+    uint8 maxOff = rootOff + static_cast<uint8>(count) * bigElSize;
     vector<WriteNode> finalOps;
     for(int4 i=0;i<moveOps.size();++i) {
       if (moveOps[i].offset < maxOff)