Version Tracker tool shows negative match numbers

[v-p-b]

Describe the bug
The Version Tracker tool displays the number of matches in subwindow titles (at least). These numbers turn negative even in case of binaries with moderate sizes. I assume this is due to Java treating all integers as signed by default. In particular, ghidra.util.table.AddressBasedTableModel.getRowCount() seems to return int (signed datatype), which is then used in VTMarkupItemsTableProvider.createTableModel() for example. A trivial solution would be to change the return value of getRowCount() to long.

To Reproduce
Steps to reproduce the behavior:

I used Windows Defender's mpengine.dll for testing:

https://github.com/taviso/loadlibrary#dependencies
https://twitter.com/buherator/status/1104469769087004673

I ran Exact Function Instruction Matcher and Exact Data Matcher against versions 1.1.15400.4 and 1.1.15400.5.

Expected behavior
Number of matches should always be a non-negative integer.

Screenshots

https://twitter.com/buherator/status/1104471786429837314

Attachments

N/A

Environment (please complete the following information):

• OS: Windows 10 64-bit
• Java Version: 11.0.2
• Ghidra Version: 9.0

Additional context

N/A

[v-p-b]

OK, never mind, it's just a missing space...