Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced modular blocks to generate separate interface #27

Merged
merged 1 commit into from
Sep 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 22 additions & 32 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,38 +123,7 @@ interface BuiltinExample {
/** Single Choice */
single_choice: "Choice 1" | "Choice 2" | "Choice 3";
/** Modular Blocks */
modular_blocks?: (
| {
block_1: {
/** Number */
number?: number;
/** Single line textbox */
single_line?: string;
};
block_2: undefined;
seo_gf: undefined;
}
| {
block_2: {
/** Boolean */
boolean?: boolean;
/** Date */
date?: string;
};
block_1: undefined;
seo_gf: undefined;
}
| {
seo_gf: {
/** Keywords */
keywords?: string;
/** Description */
description?: string;
};
block_1: undefined;
block_2: undefined;
}
)[];
modular_blocks?: ModularBlocks[];
/** Number */
number?: number;
/** Link */
Expand All @@ -166,6 +135,27 @@ interface BuiltinExample {
/** Date */
date?: string;
}

interface ModularBlocks {
block_1: {
/** Number */
number?: number;
/** Single line textbox */
single_line?: string;
};
block_2: {
/** Boolean */
boolean?: boolean;
/** Date */
date?: string;
};
seo_gf: {
/** Keywords */
keywords?: string;
/** Description */
description?: string;
};
}
```

#### 2. `graphqlTS()` (Available only for NodeJS)
Expand Down
38 changes: 19 additions & 19 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@contentstack/types-generator",
"version": "1.0.4",
"version": "2.0.0",
"description": "Contentstack type definition generation library",
"private": false,
"author": "Contentstack",
Expand Down Expand Up @@ -42,7 +42,7 @@
"typescript": "^5.4.5"
},
"dependencies": {
"@contentstack/delivery-sdk": "^4.0.5",
"@contentstack/delivery-sdk": "^4.1.0",
"@gql2ts/from-schema": "^2.0.0-4",
"axios": "^1.7.4",
"lodash": "^4.17.21",
Expand Down
51 changes: 30 additions & 21 deletions src/generateTS/factory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ export default function (userOptions: TSGenOptions) {
const visitedGlobalFields = new Set<string>();
const visitedContentTypes = new Set<string>();
const cachedGlobalFields: GlobalFieldCache = {};
const modularBlockInterfaces = new Set<string>();

const typeMap: TypeMap = {
text: { func: type_text, track: true, flag: TypeFlags.BuiltinJS },
Expand Down Expand Up @@ -233,6 +234,8 @@ export default function (userOptions: TSGenOptions) {
if (field.multiple) {
fieldType += "[]";
}
} else if (field.data_type === "blocks") {
fieldType = type_modular_blocks(field);
}
return [
field.uid + op_required(field.mandatory) + ":",
Expand Down Expand Up @@ -260,7 +263,8 @@ export default function (userOptions: TSGenOptions) {
function visit_content_type(
contentType: ContentstackTypes.ContentType | ContentstackTypes.GlobalField
) {
return [
modularBlockInterfaces.clear();
const contentTypeInterface = [
options.docgen.interface(contentType.description),
define_interface(contentType, options.systemFields),
"{",
Expand All @@ -271,29 +275,34 @@ export default function (userOptions: TSGenOptions) {
]
.filter((v) => v)
.join("\n");
}

function visit_modular_block(
field: ContentstackTypes.Field,
block: ContentstackTypes.Block
) {
return (
"{" +
[
block.uid + ":",
block.reference_to
? name_type(block.reference_to as string) + ";"
: "{" + visit_fields(block.schema || []) + "};",
].join(" ") +
visit_block_names(field, block) +
"}"
);
return [...modularBlockInterfaces, contentTypeInterface].join("\n\n");
}

function type_modular_blocks(field: ContentstackTypes.Field) {
return op_paren(
field.blocks.map((block) => visit_modular_block(field, block)).join(" | ")
);
function type_modular_blocks(field: ContentstackTypes.Field): string {
const blockInterfaceName = name_type(field.uid);
const blockInterfaces = field.blocks.map((block) => {
const fieldType =
block.reference_to && cachedGlobalFields[name_type(block.reference_to)]
? name_type(block.reference_to)
: visit_fields(block.schema || []);

const schema = block.reference_to
? `${fieldType};`
: `{\n ${fieldType} }`;
return `${block.uid}: ${schema}`;
});

const modularInterface = [
`export interface ${blockInterfaceName} {`,
blockInterfaces.join("\n"),
"}",
].join("\n");

// Store or track the generated block interface for later use
modularBlockInterfaces.add(modularInterface);

return field.multiple ? `${blockInterfaceName}[]` : blockInterfaceName;
}

function type_group(field: ContentstackTypes.Field) {
Expand Down
24 changes: 15 additions & 9 deletions tests/unit/tsgen/modular.blocks.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,26 @@ describe("modular blocks", () => {

test("definition", () => {
expect(result.definition).toMatchInlineSnapshot(`
"export interface ModularBlocks
"export interface ModularBlocks {
string_block: {
single_line?: string ;
multi_line?: string ;
markdown?: string ;
rich_text_editor?: string ; }
string_block_with_options: {
single_line_textbox_required: string ;
single_line_textbox_multiple?: string[] ; }
boolean_block: {
boolean?: boolean ; }
}

export interface ModularBlocks
{
/** Version */
_version: 2 ;
title: string ;
url: string ;
modular_blocks?: ({string_block: {single_line?: string ;
multi_line?: string ;
markdown?: string ;
rich_text_editor?: string ;};string_block_with_options: undefined;
boolean_block: undefined;} | {string_block_with_options: {single_line_textbox_required: string ;
single_line_textbox_multiple?: string[] ;};string_block: undefined;
boolean_block: undefined;} | {boolean_block: {boolean?: boolean ;};string_block: undefined;
string_block_with_options: undefined;})[] ;
modular_blocks?: ModularBlocks[] ;
}"
`);
});
Expand Down
Loading