This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
ContentAlias element now preserves original values of the aliased element #6638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I see it, we should only implement this if we do not implement #5551. |
|
Implemented in 1a46f5c. |
leofeyer
added a commit
that referenced
this pull request
Oct 31, 2014
leofeyer
pushed a commit
to contao/contao
that referenced
this pull request
Aug 20, 2019
Description ----------- # Issue (Tested in Contao 4.4) ## How to reproduce - Create a regular content element (ID 1) - Create an alias include element (ID 2) that references ID 1 - Create another alias element (ID 3) that references ID 2 Edit the original content element's template to show the element's `origId`, e. g. add: ``` data-id="<?= $this->id ?>" data-orig-id="<?= $this->origId ?>" ``` ## Result ``` data-id="1" data-orig-id="" data-id="2" data-orig-id="1" data-id="3" data-orig-id="2" ``` The `origId` is always the ID of the included element, not the ID of the original, non-alias element. ## Expected result ``` data-id="1" data-orig-id="" data-id="2" data-orig-id="1" data-id="3" data-orig-id="1" ``` The `origId` should be the ID of the original, non-alias element. # Solution Check in `Contao\ContentAlias::generate()` whether there already is an `origId` and if there is, use it. # Context Commit that introduced `origId`: 7d0e136 PR referenced in the commit: contao/core#6638 Commits ------- 9c51427 Retain origId in chained alias elements
leofeyer
pushed a commit
to contao/core-bundle
that referenced
this pull request
Aug 20, 2019
Description ----------- # Issue (Tested in Contao 4.4) ## How to reproduce - Create a regular content element (ID 1) - Create an alias include element (ID 2) that references ID 1 - Create another alias element (ID 3) that references ID 2 Edit the original content element's template to show the element's `origId`, e. g. add: ``` data-id="<?= $this->id ?>" data-orig-id="<?= $this->origId ?>" ``` ## Result ``` data-id="1" data-orig-id="" data-id="2" data-orig-id="1" data-id="3" data-orig-id="2" ``` The `origId` is always the ID of the included element, not the ID of the original, non-alias element. ## Expected result ``` data-id="1" data-orig-id="" data-id="2" data-orig-id="1" data-id="3" data-orig-id="1" ``` The `origId` should be the ID of the original, non-alias element. # Solution Check in `Contao\ContentAlias::generate()` whether there already is an `origId` and if there is, use it. # Context Commit that introduced `origId`: 7d0e13604df0bc35a1c9557cf7211c9236ddc4aa PR referenced in the commit: contao/core#6638 Commits ------- 9c514271 Retain origId in chained alias elements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ein einfacher fix für bug/request #6622
Das Alias Element überschreibt weiterhin die Werte
id,spaceundcssID- allerdings werden die alten Werte jetzt jeweils inoriginalId,originalSpaceundoriginalCssIDbeibehalten, damit Templates von eigen-entwickelten Content Elementen die Inklusion berücksichtigen können.