Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion of umlauts #635

Closed
Balindil opened this issue Nov 30, 2016 · 1 comment
Closed

Conversion of umlauts #635

Balindil opened this issue Nov 30, 2016 · 1 comment

Comments

@Balindil
Copy link

The conversion of the umlauts from the title field to the alias field does not work properly. Ä, ü, ö becomes a, u, o, and not ae, ue, oe.
@leofeyer
Copy link
Member

See #560.

@fritzmg fritzmg mentioned this issue May 21, 2017
Closed
leofeyer pushed a commit that referenced this issue Aug 20, 2019
@gmpf @leofeyer
Retain origId in chained alias elements (see #635)
74a48d8 
Description
-----------

# Issue

(Tested in Contao 4.4)

## How to reproduce

- Create a regular content element (ID 1)
- Create an alias include element (ID 2) that references ID 1
- Create another alias element (ID 3) that references ID 2

Edit the original content element's template to show the element's `origId`, e. g. add:
```
data-id="<?= $this->id ?>" data-orig-id="<?= $this->origId ?>"
```

## Result
```
data-id="1" data-orig-id=""
data-id="2" data-orig-id="1"
data-id="3" data-orig-id="2"
```
The `origId` is always the ID of the included element, not the ID of the original, non-alias element.

## Expected result
```
data-id="1" data-orig-id=""
data-id="2" data-orig-id="1"
data-id="3" data-orig-id="1"
```
The `origId` should be the ID of the original, non-alias element.

# Solution

Check in `Contao\ContentAlias::generate()` whether there already is an `origId` and if there is, use it.

# Context

Commit that introduced `origId`:
7d0e13604df0bc35a1c9557cf7211c9236ddc4aa

PR referenced in the commit:
contao/core#6638

Commits
-------

9c514271 Retain origId in chained alias elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leofeyer @Balindil