Make ZstdChunkedFooterData write-only #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
wo-binary-footer
branch
from
ce9cc0f to
0403a9c
Compare
This code path is usually never triggered because the annotations are present; and it was broken until recently. Remove it to simplify the code and analysis. Signed-off-by: Miloslav Trmač <[email protected]>
It has no non-test users any more, so decrease the size of this package (relevant to non-c/storage callers of c/image). Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Again, decrease the size of the compression code for c/image. We will simplify this further immediately. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Replace it by individual variables. Then formally deprecate the ChecksumAnnotationTarSplit field. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
We have the ImageSourceChunk data type, and we already construct these values, so scan into them directly instead of having three separate variables for the two bits of data. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
force-pushed
the
wo-binary-footer
branch
from
0403a9c to
ab5e270
Compare
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 8b0c90d
into
containers:main
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… as discussed in #1886 .
Cc: @giuseppe