Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove devicemapper storage driver #1622

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

kolyshkin
Copy link
Contributor

Fixes: #1619

@kolyshkin
Copy link
Contributor Author

kolyshkin commented May 26, 2023

Surely, we'll need a new major version after this PR.

@rhatdan
Copy link
Member

rhatdan commented May 27, 2023

I think we would need to go to podman 5.0 before we merge this in.

@TomSweeneyRedHat
Copy link
Member

Thoughts on migration from v4.0 to v5.0 when/if this comes into play?

@kolyshkin
Copy link
Contributor Author

I think we would need to go to podman 5.0 before we merge this in.

Podman is not compiling in devmapper driver since v0.9.2 (containers/podman#1445). The driver can be compiled in (I checked that), but no one knows if it works at all (I haven't checked).

@rhatdan rhatdan marked this pull request as ready for review May 30, 2023 23:00
@rhatdan
Copy link
Member

rhatdan commented May 30, 2023

Yes I agree this is not an issue for Podman. So I say we move forward on removing it.

@kolyshkin
Copy link
Contributor Author

@giuseppe
Copy link
Member

giuseppe commented Apr 9, 2024

Podman 5.0 is out, should we get this change in now?

@kolyshkin
Copy link
Contributor Author

Currently, the only user is cri-o, so it needs to be removed from it first.

The biggest roadblock seems to be cri-o/cri-o#7003 (comment). It's hard to tell if there are cri-o users who use devmapper (I hope not, but I don't know how to verify it). @haircommander maybe you can shed some light?

@rhatdan
Copy link
Member

rhatdan commented Apr 10, 2024

I would be shocked if there were any. Only possible way would be on an ancient 3.11 version, which will never get a new containers/storage version.

@haircommander
Copy link
Contributor

@fidencio @littlejawa last I remembered there was a kata case for devmapper, are we still using it there?

@littlejawa
Copy link

Talked with @fidencio about this - it seems our dependency is gone. We have an alternative to device mapper, so it can be removed.

@kolyshkin
Copy link
Contributor Author

Talked with @fidencio about this - it seems our dependency is gone. We have an alternative to device mapper, so it can be removed.

Awesome! I will revive this

Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Apr 16, 2024

/lgtm

@rhatdan
Copy link
Member

rhatdan commented Apr 16, 2024

@rhvgoyal The end of an era

@openshift-merge-bot openshift-merge-bot bot merged commit e6a80b3 into containers:main Apr 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: remove devmapper driver
7 participants