-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove devicemapper storage driver #1622
Conversation
Surely, we'll need a new major version after this PR. |
I think we would need to go to podman 5.0 before we merge this in. |
Thoughts on migration from v4.0 to v5.0 when/if this comes into play? |
Podman is not compiling in devmapper driver since v0.9.2 (containers/podman#1445). The driver can be compiled in (I checked that), but no one knows if it works at all (I haven't checked). |
Yes I agree this is not an issue for Podman. So I say we move forward on removing it. |
Need to remove it from the major users first:
|
Podman 5.0 is out, should we get this change in now? |
Currently, the only user is cri-o, so it needs to be removed from it first. The biggest roadblock seems to be cri-o/cri-o#7003 (comment). It's hard to tell if there are cri-o users who use devmapper (I hope not, but I don't know how to verify it). @haircommander maybe you can shed some light? |
I would be shocked if there were any. Only possible way would be on an ancient 3.11 version, which will never get a new containers/storage version. |
@fidencio @littlejawa last I remembered there was a kata case for devmapper, are we still using it there? |
Talked with @fidencio about this - it seems our dependency is gone. We have an alternative to device mapper, so it can be removed. |
Awesome! I will revive this |
Signed-off-by: Kir Kolyshkin <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@rhvgoyal The end of an era |
Fixes: #1619