Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not build with devicemapper #1445

Closed
wants to merge 1 commit into from
Closed

Conversation

baude
Copy link
Member

@baude baude commented Sep 11, 2018

as of now, we do not want to build with device mapper because it cannot
handle parallel requests which would be common-place in podman.

Signed-off-by: baude [email protected]

as of now, we do not want to build with device mapper because it cannot
handle parallel requests which would be common-place in podman.

Signed-off-by: baude <[email protected]>
@mheon
Copy link
Member

mheon commented Sep 11, 2018

LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM
Do we want to highlight this change in the release announcement?

@baude
Copy link
Member Author

baude commented Sep 12, 2018

bot, retest this please

1 similar comment
@rhatdan
Copy link
Member

rhatdan commented Sep 12, 2018

bot, retest this please

@rhatdan
Copy link
Member

rhatdan commented Sep 12, 2018

This of course is much more important that we do this in the RHEL/Fedora and Ubuntu spec files.
@lsm5 @fkluknav PTAL

@rhatdan
Copy link
Member

rhatdan commented Sep 12, 2018

Looks like @lsm5 is way ahead of me.

@lsm5
Copy link
Member

lsm5 commented Sep 12, 2018

@rhatdan so @baude included this change in the fedora spec file already. I'll add that to Ubuntu.

@fkluknav could you please make this change in RHEL spec files?

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mheon
Copy link
Member

mheon commented Sep 12, 2018

@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit cf528cf has been approved by mheon

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit cf528cf with merge 5c57ea2...

@rh-atomic-bot
Copy link
Collaborator

💔 Test failed - status-papr

@mheon
Copy link
Member

mheon commented Sep 12, 2018

@rh-atomic-bot retry

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit cf528cf with merge 08936c3...

@rh-atomic-bot
Copy link
Collaborator

☀️ Test successful - status-papr
Approved by: mheon
Pushing 08936c3 to master...

@baude baude deleted the nodevmapper branch December 22, 2019 18:59
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants