Support host configuration for docker-daemon sources and destinations #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
changed the title
|
Since you need to change containers/image, I changed your PR to a WIP. |
jlsalmon
changed the title
|
@rhatdan thanks, I've moved the vendor changes to containers/image#434 and unmarked the WIP |
jlsalmon
force-pushed
the
configure-daemon-host
branch
from
1176a93 to
dd0e9ad
Compare
jlsalmon
added a commit
to jlsalmon/image
that referenced
this pull request
Apr 3, 2018
To support communication with docker daemons listening on plain HTTP only, this PR makes it possible to specify the scheme as part of the host URL, e.g. `http+tcp://localhost:2375` I'm not sure if this is a good idea - I needed a way to stop the httpClient from trying to use TLS, and this seemed like a reasonable approach, similar to how the python docker client behaves. Happy to discuss and iterate on this. Relates to containers/skopeo#487 Signed-off-by: Justin Lewis Salmon <[email protected]>
mtrmac
reviewed
Apr 3, 2018
| AuthFilePath: c.String("authfile"), | ||
| DockerDaemonHost: c.String(flagPrefix + "daemon-host"), | ||
| DockerDaemonCertPath: c.String(flagPrefix + "cert-dir"), | ||
| DockerDaemonInsecureSkipTLSVerify: !c.BoolT(flagPrefix + "tls-verify"), |
There was a problem hiding this comment.
I guess reusing the cert-dir and tis-verify flags to apply to docker-daemon: as well makes sense—but their documentation throughout should be updated not to refer to “registries”.
There was a problem hiding this comment.
Good point. I've updated the docs to say "registry or daemon" - is that clear enough?
jlsalmon
added a commit
to jlsalmon/image
that referenced
this pull request
Apr 4, 2018
This PR makes it possible to communicate with docker daemons listening on plain HTTP only by specifying `http` as the url scheme e.g. `http://localhost:2375` Relates to containers/skopeo#487 Signed-off-by: Justin Lewis Salmon <[email protected]>
jlsalmon
force-pushed
the
configure-daemon-host
branch
3 times, most recently
from
d4b34f7 to
228ff2d
Compare
|
Thanks @mtrmac for the review - I've updated the docs and completions as requested. |
|
ACK, pending containers/image#434 . |
|
@jlsalmon Can you do one final update, running |
|
I have updated the vendored copy of containers/image already, so please just rebase this. |
This PR adds CLI support for overriding the default docker daemon host when using the `docker-daemon` transport. Fixes containers#244 Signed-off-by: Justin Lewis Salmon <[email protected]>
jlsalmon
force-pushed
the
configure-daemon-host
branch
from
228ff2d to
0cea6dd
Compare
|
Rebased. Thanks guys! |
|
Thanks! |
Jamesjaj2dc6j
added a commit
to Jamesjaj2dc6j/lucascalsilvaa
that referenced
this pull request
Jun 6, 2022
This PR makes it possible to communicate with docker daemons listening on plain HTTP only by specifying `http` as the url scheme e.g. `http://localhost:2375` Relates to containers/skopeo#487 Signed-off-by: Justin Lewis Salmon <[email protected]>
mrhyperbit23z0d
added a commit
to mrhyperbit23z0d/thomasdarimont
that referenced
this pull request
Jun 6, 2022
This PR makes it possible to communicate with docker daemons listening on plain HTTP only by specifying `http` as the url scheme e.g. `http://localhost:2375` Relates to containers/skopeo#487 Signed-off-by: Justin Lewis Salmon <[email protected]>
easyriderk0c9g
added a commit
to easyriderk0c9g/rnin9
that referenced
this pull request
Jun 6, 2022
This PR makes it possible to communicate with docker daemons listening on plain HTTP only by specifying `http` as the url scheme e.g. `http://localhost:2375` Relates to containers/skopeo#487 Signed-off-by: Justin Lewis Salmon <[email protected]>
oguzturker8ijm8l
added a commit
to oguzturker8ijm8l/diwir
that referenced
this pull request
Jun 6, 2022
This PR makes it possible to communicate with docker daemons listening on plain HTTP only by specifying `http` as the url scheme e.g. `http://localhost:2375` Relates to containers/skopeo#487 Signed-off-by: Justin Lewis Salmon <[email protected]>
wesnowm
added a commit
to wesnowm/MatfOOP-
that referenced
this pull request
Jun 6, 2022
This PR makes it possible to communicate with docker daemons listening on plain HTTP only by specifying `http` as the url scheme e.g. `http://localhost:2375` Relates to containers/skopeo#487 Signed-off-by: Justin Lewis Salmon <[email protected]>
gaveen3
added a commit
to gaveen3/KimJeongHoon3x
that referenced
this pull request
Jun 6, 2022
This PR makes it possible to communicate with docker daemons listening on plain HTTP only by specifying `http` as the url scheme e.g. `http://localhost:2375` Relates to containers/skopeo#487 Signed-off-by: Justin Lewis Salmon <[email protected]>
gaveen3
added a commit
to gaveen3/KimJeongHoon3x
that referenced
this pull request
Jun 6, 2022
This PR makes it possible to communicate with docker daemons listening on plain HTTP only by specifying `http` as the url scheme e.g. `http://localhost:2375` Relates to containers/skopeo#487 Signed-off-by: Justin Lewis Salmon <[email protected]>
Manuel-Suarez-Abascal80n9y
added a commit
to Manuel-Suarez-Abascal80n9y/knimeu
that referenced
this pull request
Oct 7, 2022
This PR makes it possible to communicate with docker daemons listening on plain HTTP only by specifying `http` as the url scheme e.g. `http://localhost:2375` Relates to containers/skopeo#487 Signed-off-by: Justin Lewis Salmon <[email protected]>
straiforos8bsh5n
added a commit
to straiforos8bsh5n/tokingsq
that referenced
this pull request
Oct 7, 2022
This PR makes it possible to communicate with docker daemons listening on plain HTTP only by specifying `http` as the url scheme e.g. `http://localhost:2375` Relates to containers/skopeo#487 Signed-off-by: Justin Lewis Salmon <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CLI support for overriding the default docker daemon host when using the
docker-daemontransport.See also containers/image#434
Fixes #244
Signed-off-by: Justin Lewis Salmon [email protected]