Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker daemon host need to be configurable #244

Closed
hustcat opened this issue Nov 3, 2016 · 8 comments
Closed

Docker daemon host need to be configurable #244

hustcat opened this issue Nov 3, 2016 · 8 comments
Labels
locked - please file new issue/PR

Comments

@hustcat
Copy link

hustcat commented Nov 3, 2016

Docker daemon host can't be configurable.
@hustcat hustcat mentioned this issue Nov 3, 2016
Closed
@jlsalmon
Copy link
Contributor

Is this possible yet?

@rhatdan
Copy link
Member

rhatdan commented Mar 29, 2018

It should be able to be. Reopen if your use fails.

@rhatdan rhatdan closed this as completed Mar 29, 2018
@jlsalmon
Copy link
Contributor

I would reopen but I'm not the author.

skopeo copy doesn't seem to honour DOCKER_HOST:

$ echo $DOCKER_HOST
tcp://myhost.local:2375
$ skopeo copy docker://busybox:latest docker-daemon:busybox:latest
Getting image source signatures
Copying blob sha256:d070b8ef96fc4f2d92ff520a4fe55594e362b4e1076a32bbfeb261dc03322910
 0 B / 706.17 KB [-------------------------------------------------------------]
FATA[0006] Error writing blob: Error saving image to docker engine: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

Maybe I'm missing something?

@rhatdan rhatdan reopened this Mar 29, 2018
@rhatdan
Copy link
Member

rhatdan commented Mar 29, 2018

@mtrmac @runcom Any ideas?

@mtrmac
Copy link
Contributor

mtrmac commented Mar 29, 2018

There is containers/image#328 , designed so that the caller must intentionally opt in into a different configuration, instead of silently changing behavior depending on the environment.

skopeo does not currently expose this configuration (types.SystemContext.DockerDaemon{Host,CertPath}) via the CLI.

@jlsalmon
Copy link
Contributor

Thanks guys. Would I then be correct in saying that it would be a fairly simple addition to the skopeo CLI?

jlsalmon added a commit to jlsalmon/skopeo that referenced this issue Mar 30, 2018
@jlsalmon
Support host configuration for docker-daemon sources and destinations
731b194 
This PR adds CLI support for overriding the default docker daemon host when using the
`docker-daemon` transport.

Additionally, to support daemons listening on plain HTTP only, it is possible to
specify the scheme as part of the host URL, e.g. `http+tcp://localhost:2375`

I'm not sure if this is a good idea - I needed a way to stop the httpClient from
trying to use TLS, and this seemed like a reasonable approach, similar to how the
python docker client behaves. Happy to discuss and iterate on this.

I'm guessing that I'd need to sumbit that part upstream to `containers/image` anyway.

Fixes containers#244
@jlsalmon jlsalmon mentioned this issue Mar 30, 2018
Merged
@rhatdan
Copy link
Member

rhatdan commented Mar 30, 2018

Sure, open a PR, l

@jlsalmon
Copy link
Contributor

I had a quick shot at this in #487

@jlsalmon jlsalmon mentioned this issue Apr 3, 2018
Merged
jlsalmon added a commit to jlsalmon/skopeo that referenced this issue Apr 3, 2018
@jlsalmon
Support host configuration for docker-daemon sources and destinations
dd0e9ad 
This PR adds CLI support for overriding the default docker daemon host when using the
`docker-daemon` transport.

Fixes containers#244

Signed-off-by: Justin Lewis Salmon <[email protected]>
jlsalmon added a commit to jlsalmon/skopeo that referenced this issue Apr 4, 2018
@jlsalmon
Support host configuration for docker-daemon sources and destinations
ff9495d 
This PR adds CLI support for overriding the default docker daemon host when using the
`docker-daemon` transport.

Fixes containers#244

Signed-off-by: Justin Lewis Salmon <[email protected]>
jlsalmon added a commit to jlsalmon/skopeo that referenced this issue Apr 4, 2018
@jlsalmon
Support host configuration for docker-daemon sources and destinations
d4b34f7 
This PR adds CLI support for overriding the default docker daemon host when using the
`docker-daemon` transport.

Fixes containers#244

Signed-off-by: Justin Lewis Salmon <[email protected]>
jlsalmon added a commit to jlsalmon/skopeo that referenced this issue Apr 4, 2018
@jlsalmon
Support host configuration for docker-daemon sources and destinations
228ff2d 
This PR adds CLI support for overriding the default docker daemon host when using the
`docker-daemon` transport.

Fixes containers#244

Signed-off-by: Justin Lewis Salmon <[email protected]>
jlsalmon added a commit to jlsalmon/skopeo that referenced this issue Apr 7, 2018
@jlsalmon
Support host configuration for docker-daemon sources and destinations
0cea6dd 
This PR adds CLI support for overriding the default docker daemon host when using the
`docker-daemon` transport.

Fixes containers#244

Signed-off-by: Justin Lewis Salmon <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked - please file new issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support configure docker daemon with environment variables hustcat/image
4 participants
@jlsalmon @hustcat @rhatdan @mtrmac