Add support for SoC separate var partition #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yarboa
requested review from
rhatdan,
lsm5,
dougsland,
odra,
sandrobonazzola,
dennisbrendel and
priyverm
as code owners
|
I don't believe these are related to your change, already exists as we talked. Should be okay to merge as soon you have a final patch. /tests/ffi/memory (timeout) /tests/ffi/qm-oom-score-adj |
|
Output from CI/CD also from your patch (pids exists from cgroup2): |
Yarboa
force-pushed
the
pinst-var-part
branch
4 times, most recently
from
14e5ce0
to
5adffd8
Compare
Yarboa
force-pushed
the
pinst-var-part
branch
2 times, most recently
from
ae03585
to
5ec8b93
Compare
|
@dougsland ready to merge, if now comments |
dougsland
reviewed
Aug 29, 2024
dougsland
reviewed
Aug 29, 2024
dougsland
reviewed
Aug 29, 2024
Yarboa
force-pushed
the
pinst-var-part
branch
2 times, most recently
from
5380cfd
to
90544ff
Compare
dougsland
reviewed
Aug 30, 2024
dougsland
reviewed
Aug 30, 2024
dougsland
reviewed
Aug 30, 2024
Yarboa
force-pushed
the
pinst-var-part
branch
2 times, most recently
from
b4828e5
to
b4ec46a
Compare
dougsland
reviewed
Aug 30, 2024
Updating tests/e2e/set-ffi-env-e2e to mkfs.ext4 On free sde partiton it finds Move disk functions to lib/diskutils script Increase timers for memory and qm-oom-score-adj Signed-off-by: Yariv Rachmani <[email protected]>
dougsland
reviewed
Aug 31, 2024
|
|
||
| for disk in $disks_arr; do | ||
| if [[ ${disk} == "vda" || \ | ||
| $(echo "${disk_table}" | grep -c "${disk}" ) -eq 1 && ${disk} != "zram0" ]];then |
There was a problem hiding this comment.
looks like out of indent
dougsland
reviewed
Aug 31, 2024
| fi | ||
|
|
||
| mkdir -p /new_var | ||
| mount "/dev/${DISK}${PART_ID}" /new_var |
dougsland
reviewed
Aug 31, 2024
| mount "/dev/${DISK}${PART_ID}" /new_var | ||
| rsync -aqxXP /var/* /new_var | ||
| if_error_exit "Error: rsync failed" | ||
| systemctl stop var-lib-nfs-rpc_pipefs.mount |
There was a problem hiding this comment.
if_error_exit? if not, better comment.
dougsland
reviewed
Aug 31, 2024
| rsync -aqxXP /var/* /new_var | ||
| if_error_exit "Error: rsync failed" | ||
| systemctl stop var-lib-nfs-rpc_pipefs.mount | ||
| umount /new_var |
There was a problem hiding this comment.
if_error_exit? or just warning? or just echo before ?
dougsland
reviewed
Aug 31, 2024
| echo | ||
| info_message "Checking if QM already installed" | ||
| info_message "==============================" | ||
| QM_STATUS="$(systemctl is-enabled qm 2>&1)" | ||
| if [ "$QM_STATUS" == "generated" ]; then | ||
| if [ "$(systemctl is-active qm)" == "active" ]; then | ||
| # Restart QM after mount /var on separate partition | ||
| if grep -qi "${QC_SOC}" "${SOC_DISTRO_FILE}"; then | ||
| systemctl restart qm |
|
The patch is okay to merge now, we can handle the rest in a next patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating tests/e2e/set-ffi-env-e2e to mkfs.ext4
On free sde partiton it finds VROOM-21987