Patch for common.sh #509
Merged
Patch for common.sh #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nsednev <[email protected]>
nsednev
requested review from
rhatdan,
lsm5,
dougsland,
Yarboa,
odra,
sandrobonazzola,
dennisbrendel and
priyverm
as code owners
dougsland
reviewed
Aug 22, 2024
|
In another patch, also start using it in your test so we can show this really works. |
|
safe to merge, this is just CI/CD flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dougsland suggested to add this patch to prepare.sh, so people will be able to init the ffi, by calling single init_ffi function, which includes all three functions (disk_cleanup, prepare_test, at once in their code, reload_config), instead of calling 3 of them one by one in their code.