qm.if: fix syntax errors #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix syntax errors when running sepolgen-ifgen: ``` /usr/share/selinux/devel/include/services/qm.if: Syntax error on line 398 ) [type=CPAREN] /usr/share/selinux/devel/include/services/qm.if: Syntax error on line 399 ) [type=CPAREN] /usr/share/selinux/devel/include/services/qm.if: Syntax error on line 400 ) [type=CPAREN] /usr/share/selinux/devel/include/services/qm.if: Syntax error on line 558 ' [type=SQUOTE] /usr/share/selinux/devel/include/services/qm.if: Syntax error on line 621 ) [type=CPAREN] /usr/share/selinux/devel/include/services/qm.if: Syntax error on line 622 ) [type=CPAREN] /usr/share/selinux/devel/include/services/qm.if: Syntax error on line 623 ) [type=CPAREN] ``` Signed-off-by: Albert Esteve <[email protected]>
aesteve-rh
requested review from
rhatdan,
lsm5,
dougsland,
Yarboa,
odra,
sandrobonazzola,
dennisbrendel and
priyverm
as code owners
|
@Yarboa it may be nice to have a syntax checker in the pipelines to prevent future issues. Not sure if there is one such tool, but I assume there must be? |
|
@aesteve-rh , @Yarboa here's the tool: https://github.com/SELinuxProject/selint ; would be great if it can be just added to pre-commit hooks :-) |
|
After giving it a try, not sure selint can be used, it tests the whole selinux system, not just the file itself. $ selint qm.if
Note: Check E-007 is not performed because no permission macro has been parsed.
/usr/share/selinux/devel/include/contrib/virt.if:169: (F): syntax error, unexpected UNKNOWN_TOKEN (F-001)
169 | filetrans_pattern($1, virt_var_run_t, virtinterfaced_var_run_t, dir, "``interface''")
| ^
/usr/share/selinux/devel/include/contrib/virt.if:169: (F): Error: Invalid statement (F-001)
169 | filetrans_pattern($1, virt_var_run_t, virtinterfaced_var_run_t, dir, "``interface''")
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error: Failed to parse files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix syntax errors when running sepolgen-ifgen: