-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setup script #443
Fix setup script #443
Conversation
|
0eb28f3
to
a21bee0
Compare
/packit test --identifier e2e-ffi |
@@ -38,18 +37,18 @@ exec_command() { | |||
fi | |||
|
|||
# print the output of QM ROOTFS | |||
echo $($COMMAND) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the idea here was just print, not execute. With the result of this echo the other function would do something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look here
some how it returned as an input value and the output
19:28:08 out: Exiting... unable to find /usr/share/qm/qm-rootfs/etc/containers/storage.conf
At the end if no exec run the output is the /usr/share/qm/qm-rootfs
so there is a need to run it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just leave the bash header as it's and this one as well but I will check tomorrow. I might be little "snow" as it's holiday here but I will check.
9c5401a
to
316d8e2
Compare
71b3eb4
to
78462b0
Compare
tools/qm-storage-settings
Outdated
STORAGE_CONFIG="/run/osbuild/tree/${STORAGE_CONFIG}" | ||
if [ ! -f "${STORAGE_CONFIG}" ]; then | ||
echo "Exiting /etc/containers/storage.conf in the ROOTFS" | ||
echo "Exiting /etc/containers/storage.confnot found under /run/osbuild/tree/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing a space.
just cosmetic comments but looks good, CI/CD seems to agree as well. :) |
Also remove gh cli, it's repo returns 443 lately Signed-off-by: Yariv Rachmani <[email protected]>
resolve #439
Setup script or qm rpm does not call qm-storage-settings,
qm-storage-settings set qm storage.conf
Some more bash shell check fixes added