-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-disable sdnotify tests to try to fix CI #7354
Re-disable sdnotify tests to try to fix CI #7354
Conversation
Some CI tests are hanging, timing out in 60 or 120 minutes. I wonder if it's containers#7316, the bug where all podman commands hang forever if NOTIFY_SOCKET is set? Signed-off-by: Ed Santiago <[email protected]>
@cevich @mheon @vrothberg @rhatdan it looks like the CI hang is caused by my #7317 (enable sdnotify tests). I don't understand the failure symptom, or why initial CI didn't catch this, but the fact that this PR has passed CI is enough to tell me that sdnotify is the culprit. All open PRs will have to be rebased against this to pass CI. I don't know how to proceed with reenabling these tests, if ever. Maybe if the SDNOTIFY hang gets fixed. I also need to understand why there was never any useful output from test logs. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some CI tests are hanging, timing out in 60 or 120 minutes.
I wonder if it's #7316, the bug where all podman commands
hang forever if NOTIFY_SOCKET is set?
Signed-off-by: Ed Santiago [email protected]