Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-disable sdnotify tests to try to fix CI #7354

Merged

Conversation

edsantiago
Copy link
Member

Some CI tests are hanging, timing out in 60 or 120 minutes.
I wonder if it's #7316, the bug where all podman commands
hang forever if NOTIFY_SOCKET is set?

Signed-off-by: Ed Santiago [email protected]

Some CI tests are hanging, timing out in 60 or 120 minutes.
I wonder if it's containers#7316, the bug where all podman commands
hang forever if NOTIFY_SOCKET is set?

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago
Copy link
Member Author

@cevich @mheon @vrothberg @rhatdan it looks like the CI hang is caused by my #7317 (enable sdnotify tests). I don't understand the failure symptom, or why initial CI didn't catch this, but the fact that this PR has passed CI is enough to tell me that sdnotify is the culprit. All open PRs will have to be rebased against this to pass CI.

I don't know how to proceed with reenabling these tests, if ever. Maybe if the SDNOTIFY hang gets fixed. I also need to understand why there was never any useful output from test logs.

@rhatdan
Copy link
Member

rhatdan commented Aug 18, 2020

/approve
LGTM

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2020
@mheon
Copy link
Member

mheon commented Aug 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2020
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-merge-robot openshift-merge-robot merged commit 748e882 into containers:master Aug 18, 2020
@edsantiago edsantiago deleted the redisable_sdnotify branch August 18, 2020 15:11
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants