Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: TESTING: DO NOT MERGE #7342

Closed
wants to merge 1 commit into from

Conversation

cevich
Copy link
Member

@cevich cevich commented Aug 17, 2020

Signed-off-by: Chris Evich [email protected]

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cevich
To complete the pull request process, please assign rhatdan
You can assign the PR to them by writing /assign @rhatdan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cevich cevich force-pushed the repro_no_output_hang branch 2 times, most recently from cc3b4ad to 8b7a2ba Compare August 17, 2020 18:51
@cevich
Copy link
Member Author

cevich commented Aug 17, 2020

@edsantiago I think the spot you're seeing the "hang" is a red-herring, I think something's happening on another level to cause this. Look at the example from this PR: https://cirrus-ci.com/task/5905973485240320?command=system_test#L156 Execution simply/literally stops w/o notice, until the "BIG" timeout clobbers it. All the other tests passed, so...geeze...the only thing I can think is something must be happening on the cirrus side. Maybe related to the underlying VMs being preemptable and a secondary bug related to output processing when that happens? https://cloud.google.com/compute/docs/instances/preemptible

@cevich
Copy link
Member Author

cevich commented Aug 17, 2020

....Actually, no...scratch that. Our VMs are NOT preemptable...we use the expensive ones 😕

@edsantiago
Copy link
Member

FWIW: acting on the possibility that the env bash PR could be responsible, I rebased my two PRs on the commit prior to that. No luck on either one: both ran into the 60- and 120-minute timeout, same tests, same symptoms.

@cevich
Copy link
Member Author

cevich commented Aug 18, 2020

FWIW: acting on the possibility that the env bash PR could be responsible

Excellent, thanks for trying that. One more question-mark item we can check off the list.

ONE of my tests also hit the 120min timeout: https://github.com/containers/podman/pull/7342/checks?check_run_id=995072852 but appears almost totally different from yours. I'm taking this as meaning the problem isn't specific to your PR, and we should basically expect to see this problem appear everywhere.

I'm going to try and re-run it to see if the behavior changes at all (IIRC, yours always failed for at least 3-5 retries).

Signed-off-by: Chris Evich <[email protected]>
@cevich cevich force-pushed the repro_no_output_hang branch from 8b7a2ba to 8ea8c0e Compare August 18, 2020 14:24
@cevich
Copy link
Member Author

cevich commented Aug 18, 2020

Problem fixed by #7354

@cevich cevich closed this Aug 18, 2020
@cevich cevich deleted the repro_no_output_hang branch June 30, 2021 18:06
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants