Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use conmon v1.0.0-rc2 #3620

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

haircommander
Copy link
Collaborator

partial pick of #3143 to get the in_podman image updated so the test passes

Signed-off-by: Peter Hunt [email protected]

@mheon
Copy link
Member

mheon commented Jul 22, 2019

Either Cirrus is down, or Github is still having issues. Regardless, I think test issues aren't the fault of this PR.

Signed-off-by: Peter Hunt <[email protected]>
@cevich
Copy link
Member

cevich commented Jul 22, 2019

LGTM

@baude
Copy link
Member

baude commented Jul 22, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2019
@baude
Copy link
Member

baude commented Jul 22, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2019
@haircommander
Copy link
Collaborator Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2019
@mheon
Copy link
Member

mheon commented Jul 22, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2019
@openshift-merge-robot openshift-merge-robot merged commit cf9efa9 into containers:master Jul 22, 2019
@haircommander haircommander deleted the bump-conmon branch July 22, 2019 19:54
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants