-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add another Fedora VM with cgroups v2 enabled #3607
Conversation
/cc @giuseppe getting started on this, just in case. I think I touched all the right places for a new VM image, but we'll see soon enough 😄 ... |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@giuseppe so as you saw, there's no built-in way to safely reboot during testing. Though a newly added unrelated feature, does support this possibility in "future Cirrus-CI". For now, we'll have to add a snowflake VM image, which this PR should do. What were you thinking about for testing, should it execute the regular integration tests for now? Either way, I need to update this comment. |
☔ The latest upstream changes (presumably #3620) made this pull request unmergeable. Please resolve the merge conflicts. |
I was thinking of running the e2e tests using crun instead of runc |
Ahh okay, not sure what that is, but IIRC we can affect that by exporting |
193cd5f
to
307f93c
Compare
90f0d64
to
c9cb405
Compare
☔ The latest upstream changes (presumably #3632) made this pull request unmergeable. Please resolve the merge conflicts. |
/hold
Something send to be stalling this, will investigate when I get to a
computer
…On Sat, Aug 10, 2019, 05:46 Daniel J Walsh ***@***.***> wrote:
/hold cancel
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3607>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB3AOCAU4BHQEWN5RO6PDULQD2FARANCNFSM4IFGYGCQ>
.
|
@cevich could you rebase it? I've moved crun under github.com/containers. Once we set up tests with cgroups v2, we will probably want to setup some tests on the crun repository as well to avoid regressions |
Can they be performed inside a container? I'm happy to help, but there's one "implement CI on $REPO" request ahead of it. Rebasing this, rebuilding images, and re-testing... |
/lgtm |
Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: Chris Evich <[email protected]>
/lgtm |
/hold cancel |
Depends on #3632