Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another Fedora VM with cgroups v2 enabled #3607

Merged
merged 4 commits into from
Aug 12, 2019

Conversation

cevich
Copy link
Member

@cevich cevich commented Jul 19, 2019

Depends on #3632

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2019
@cevich
Copy link
Member Author

cevich commented Jul 19, 2019

/cc @giuseppe getting started on this, just in case. I think I touched all the right places for a new VM image, but we'll see soon enough 😄 ...

@rhatdan
Copy link
Member

rhatdan commented Jul 20, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2019
@cevich cevich changed the title WIP: Cgroup2 vm WIP: Add another Fedora VM with cgroups v2 enabled Jul 22, 2019
@cevich
Copy link
Member Author

cevich commented Jul 22, 2019

@giuseppe so as you saw, there's no built-in way to safely reboot during testing. Though a newly added unrelated feature, does support this possibility in "future Cirrus-CI". For now, we'll have to add a snowflake VM image, which this PR should do.

What were you thinking about for testing, should it execute the regular integration tests for now? Either way, I need to update this comment.

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #3620) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2019
@giuseppe
Copy link
Member

What were you thinking about for testing, should it execute the regular integration tests for now? Either way, I need to update this comment.

I was thinking of running the e2e tests using crun instead of runc

@cevich
Copy link
Member Author

cevich commented Jul 23, 2019

I was thinking of running the e2e tests using crun instead of runc

Ahh okay, not sure what that is, but IIRC we can affect that by exporting $RUNC_BINARY. While I'm messing with adding a new cache-image anyway, how do I make "crun" available?

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2019
@cevich cevich force-pushed the cgroup2_vm branch 2 times, most recently from 193cd5f to 307f93c Compare July 24, 2019 15:02
@cevich cevich force-pushed the cgroup2_vm branch 3 times, most recently from 90f0d64 to c9cb405 Compare July 25, 2019 14:32
@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #3632) made this pull request unmergeable. Please resolve the merge conflicts.

@mheon
Copy link
Member

mheon commented Aug 10, 2019 via email

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 10, 2019
@giuseppe
Copy link
Member

@cevich could you rebase it?

I've moved crun under github.com/containers. Once we set up tests with cgroups v2, we will probably want to setup some tests on the crun repository as well to avoid regressions

@cevich
Copy link
Member Author

cevich commented Aug 12, 2019

we will probably want to setup some tests on the crun repository as well to avoid regressions

Can they be performed inside a container? I'm happy to help, but there's one "implement CI on $REPO" request ahead of it.

Rebasing this, rebuilding images, and re-testing...

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 12, 2019
@rhatdan
Copy link
Member

rhatdan commented Aug 12, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2019
@cevich cevich changed the title Add another Fedora VM with cgroups v2 enabled WIP: Add another Fedora VM with cgroups v2 enabled Aug 12, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2019
@cevich cevich changed the title WIP: Add another Fedora VM with cgroups v2 enabled Add another Fedora VM with cgroups v2 enabled Aug 12, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2019
@rhatdan
Copy link
Member

rhatdan commented Aug 12, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2019
@cevich
Copy link
Member Author

cevich commented Aug 12, 2019

@giuseppe @mheon @baude this one is ready whenever y'all are.

@rhatdan
Copy link
Member

rhatdan commented Aug 12, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2019
@openshift-merge-robot openshift-merge-robot merged commit f634fd3 into containers:master Aug 12, 2019
@cevich cevich deleted the cgroup2_vm branch June 30, 2021 18:04
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants