Quadlet add support for --add-host --ip and --ip6

[jerome59]

Fixes: #23692

• Add support for --add-host for Pod and Container units. It is possible to specify multiple hosts for a single IP.
• Add support for IP and IP6 for Pod units.

Does this PR introduce a user-facing change?

Podman Quadlet Pod and Containers now supports AddHost
Podman Quadlet Pod now supports  IP and IP6

[ygalblum]

Thanks for the contribution. 2 small comments.
In addition, since you define the structure for the AddHost key and return errors on invalid values, please add negative test cases as well. You can find examples in this table: https://github.com/containers/podman/blob/main/test/e2e/quadlet_test.go#L1018

[ygalblum]

LGTM

[Luap99]

I am not sure I like a new different syntax for only quadlet files. IMO the syntax should match podman cli as much as possible.

So if you really think this syntax is needed then it should go into podman proper so there are not random syntax differences for the option values.

[Luap99]

What is the point of inventing a new syntax? If you want multiple hosts entries specify them several times.
I am not sure why this extra complexity is needed over the simple

addHosts := quadletUnitFile.LookupAll(groupName, KeyAddHost)
for _, addHost := range addHosts {
	podman.add("--add-host=" + addHost)
}

[jerome59]

We have an application which needs a lots of entry in the host files and multiple hostname refer to the same IP.

With kube play (or also directly by editing the hosts file), we can set multiple hostname for an IP without duplicating that IP. I think it helps with the clarity of the file.

However, I agree that it would be better if it wasn't a quadlet specific syntax. Beginning of next week I will remove this specificity from the PR.

[Luap99]

please squash your fixup commits into the AddHost commit, having two commit for IP and AddHost is great but having extra commits that remove features/fix bug from an earlier commit in the PR should juts be squashed into the original commit adding them.

[Luap99]

/lgtm

Thanks, If you like to have the several host for one ip syntax I suggest you file a new issue so we can consider this for the proper podman cli. Then quadlet units could use it without further changes.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerome59, Luap99, ygalblum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99,ygalblum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jerome59]

@Luap99 : Thanks for the merge. I've opened the issue regarding the new syntax #23770 so it can be discussed there.