Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quadlet add support for --add-host #23692

Closed
jerome59 opened this issue Aug 21, 2024 · 1 comment · Fixed by #23713
Closed

Quadlet add support for --add-host #23692

jerome59 opened this issue Aug 21, 2024 · 1 comment · Fixed by #23713
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet

Comments

@jerome59
Copy link
Contributor

Feature request description

In a quadlet file, I don't see any options equivalent to the --add-host of the podman run command.
Today if we want to add some hosts, we need to do :
PodmanArgs=--add-host my-host-name:192.168.10.10 --add-host my-second-host-name:192.168.10.10 --add-host my-third-host-name:192.168.10.11

Suggest potential solution

For Pod and Container units, I'd like to have a key AddHost which allows me to define the same behavior as the --add-host argument.

Example :

AddHost=my-host-name:192.168.10.10
AddHost=my-second-host-name:192.168.10.10
AddHost=my-third-host-name:192.168.10.11

If possible, it would even be better if we can define multiple hostnames for a single IP at once. The previous example would look like :

AddHost=my-host-name;my-second-host-name:192.168.10.10
AddHost=my-third-host-name:192.168.10.11

Have you considered any alternatives?

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@jerome59 jerome59 added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 21, 2024
@rhatdan
Copy link
Member

rhatdan commented Aug 21, 2024

Please open a PR to add it.

@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Nov 26, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants