Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.9] Remove gitleaks scanning #21619

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

cevich
Copy link
Member

@cevich cevich commented Feb 12, 2024

Ref: #21588

Does this PR introduce a user-facing change?

None

@cevich cevich changed the title [v4.0] Remove gitleaks scanning [v4.9] Remove gitleaks scanning Feb 12, 2024
Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
@lsm5
Copy link
Member

lsm5 commented Feb 13, 2024

tests aren't happy with the removal

@cevich
Copy link
Member Author

cevich commented Feb 13, 2024

Oh woops, I missed a spot.

@cevich cevich force-pushed the v4.9_remove_secret_scan branch from 35658c1 to f8f0dc0 Compare February 13, 2024 18:46
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
@mheon
Copy link
Member

mheon commented Feb 13, 2024

Validate is angry

Ref: containers#21588

[NO NEW TESTS NEEDED]

Signed-off-by: Chris Evich <[email protected]>
@cevich cevich force-pushed the v4.9_remove_secret_scan branch from f8f0dc0 to 34fc193 Compare February 13, 2024 19:39
@cevich
Copy link
Member Author

cevich commented Feb 13, 2024

Ugh, thanks. It's never easy. One more time...

@cevich
Copy link
Member Author

cevich commented Feb 14, 2024

This is ready finally.

@mheon
Copy link
Member

mheon commented Feb 14, 2024

/hold cancel
/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 947a962 into containers:v4.9 Feb 14, 2024
88 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label May 15, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants