[CI:DOCS] Remove gitleaks scanning #21588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: containers#21570 (comment) This tool is really intended/best used from git pre-commit on developers local machines, to prevent addition of secret leaks. When used as a check against PRs, it tends to turn up more false-positives than helpful warnings. There's no good way to fix this, and maintaining the scanner is an additional burden. Rather than continue struggling to improve/fix the situation, let's just remove the tool entirely. Signed-off-by: Chris Evich <[email protected]>
openshift-ci
bot
added
the
do-not-merge/release-note-label-needed
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
openshift-merge-bot
bot
merged commit 3ba674d
into
containers:main
37 of 38 checks passed
cevich
added a commit
to cevich/podman
that referenced
this pull request
Feb 13, 2024
Ref: containers#21588 [NO NEW TESTS NEEDED] Signed-off-by: Chris Evich <[email protected]>
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref:
#21570 (comment)
This tool is really intended/best used from git pre-commit on developers local machines, to prevent addition of secret leaks. When used as a check against PRs, it tends to turn up more false-positives than helpful warnings. There's no good way to fix this, and maintaining the scanner is an additional burden. Rather than continue struggling to improve/fix the situation, let's just remove the tool entirely.
Does this PR introduce a user-facing change?