Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused archive flag from diff commands #14364

Merged
merged 1 commit into from
May 25, 2022
Merged

Remove unused archive flag from diff commands #14364

merged 1 commit into from
May 25, 2022

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented May 25, 2022

  • Option left in images/diff.go CLI as comment implies it is needed for
    backwards compatibility.
NONE

[NO NEW TESTS NEEDED]

Signed-off-by: Jhon Honce [email protected]

@jwhonce jwhonce added the kind/cleanup Categorizes issue or PR as related to cleanup. label May 25, 2022
@jwhonce jwhonce requested a review from Luap99 May 25, 2022 15:23
@jwhonce jwhonce self-assigned this May 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2022
@jwhonce jwhonce requested a review from umohnani8 May 25, 2022 15:25
Luap99
Luap99 reviewed May 25, 2022
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you only keep the flag for images, removing it is a breaking change and should not be done until 5.0 IMO.

@umohnani8
Copy link
Member

LGTM

@jwhonce
Copy link
Member Author

jwhonce commented May 25, 2022 •
edited
Loading

Why do you only keep the flag for images, removing it is a breaking change and should not be done until 5.0 IMO.

I left it in images because of the deprecation text (No idea who we are being compatible with...). As the flag has always been hidden, I did not think we needed to wait. If you feel strongly, I can pull it from the Options struct and just leave it in the CLI.

Flag is not included in any of the man pages.

@Luap99
Copy link
Member

Luap99 commented May 25, 2022

I left it in images because of the deprecation text (No idea who we are being compatible with...)

Well I do not know either so I would rather not change it without knowing the consequences.

I also find it very inconsistent to only keep it for one command. IMO either remove it for all or keep it for all.

@jwhonce
Remove unused archive flag from diff commands
338f012 
* Option left in images/diff.go CLI as comment implies it is needed for
  backwards compatibility.

```release-note
NONE
```

[NO NEW TESTS NEEDED]

Signed-off-by: Jhon Honce <[email protected]>
TomSweeneyRedHat
TomSweeneyRedHat reviewed May 25, 2022
View reviewed changes
cmd/podman/diff/diff.go
@@ -13,7 +13,7 @@ import (
"github.com/spf13/cobra"
)

func Diff(cmd *cobra.Command, args []string, options entities.DiffOptions) error {
func Diff(_ *cobra.Command, args []string, options entities.DiffOptions) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just drop this entirely? Or is it exposed externally and it would be an API break.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomSweeneyRedHat the cobra method signature requires this parameter.

@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2022
@openshift-merge-robot openshift-merge-robot merged commit e11feb2 into containers:main May 25, 2022
@edsantiago edsantiago mentioned this pull request Jun 1, 2022
Closed
@edsantiago edsantiago mentioned this pull request Jun 13, 2022
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@jwhonce jwhonce

@TomSweeneyRedHat TomSweeneyRedHat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleanup. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jwhonce @umohnani8 @Luap99 @TomSweeneyRedHat @openshift-merge-robot