Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tail 800 lines journald: incomplete output #14362

Closed
edsantiago opened this issue May 25, 2022 · 7 comments · Fixed by #14443
Closed

tail 800 lines journald: incomplete output #14362

edsantiago opened this issue May 25, 2022 · 7 comments · Fixed by #14443
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

Two flakes in one week:

# podman-remote [options] logs --tail 800 <CID>
...
...makes it only to 400-something, or perhaps even just zero lines
? Failure [3.295 seconds]
         Podman logs
         /var/tmp/go/src/github.com[/containers/podman/test/e2e/logs_test.go:26](https://github.com/containers/podman/blob/e874fc105c0fcfa291e256071be8b48dc4f347f8/test/e2e/logs_test.go#L26)
           tail 800 lines: journald [It]
           /var/tmp/go/src/github.com[/containers/podman/test/e2e/logs_test.go:116](https://github.com/containers/podman/blob/e874fc105c0fcfa291e256071be8b48dc4f347f8/test/e2e/logs_test.go#L116)
         
           Expected [long string] to have length 800

Podman logs [It] tail 800 lines: journald

@edsantiago edsantiago added flakes Flakes from Continuous Integration remote Problem is in podman-remote labels May 25, 2022
@github-actions github-actions bot removed the remote Problem is in podman-remote label May 25, 2022
@Luap99
Copy link
Member

Luap99 commented Jun 1, 2022

I think I saw this on many PRs recently.
@edsantiago Can you post the recent failures to check if it is only on remote?

@edsantiago
Copy link
Member Author

Two more on 05-25, none since then (but then again, long weekend with very very few PRs)

Podman logs [It] tail 800 lines: journald

@Luap99
Copy link
Member

Luap99 commented Jun 1, 2022

@edsantiago
Copy link
Member Author

Ah yes, I should've mentioned my flake logger only captures merged PRs. Identifying flakes on in-progress PRs was an exercise I deferred "for later" (and has not happened yet).

@edsantiago
Copy link
Member Author

Anyhow: the logs above show one instance on non-remote, and curiously it was a one-time-only: the remote failures are all three-time failures.

@Luap99
Copy link
Member

Luap99 commented Jun 1, 2022

Just any idea but the test never actually waits for the container to complete. It call podman run -d ... followed by podman logs.
I think it is likely that the container/conmon did not write all the output before we call logs.

Let me open a PR with an extra podman wait then we will see if that worked or not.

@vrothberg
Copy link
Member

That sounds plausible. Nice catch, @Luap99.

Luap99 added a commit to Luap99/libpod that referenced this issue Jun 1, 2022
The test calls podman run -d followed by podman logs. There is no
guarantee the the container or conmon has written all its output.
Adding an extra podman wait should fix this.

Do not remove the -d to not print 1000 unnecessary lines in the logs.

Fixes containers#14362

Signed-off-by: Paul Holzinger <[email protected]>
mheon pushed a commit to mheon/libpod that referenced this issue Jun 14, 2022
The test calls podman run -d followed by podman logs. There is no
guarantee the the container or conmon has written all its output.
Adding an extra podman wait should fix this.

Do not remove the -d to not print 1000 unnecessary lines in the logs.

Fixes containers#14362

Signed-off-by: Paul Holzinger <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants