-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
events Rest API changes in v1.12 #7078
Comments
Ok that is bad. |
I am wondering if this was the parameter type change from @vrothberg from I'm also curious as to why the Docker endpoint is being used here - thought Cockpit was using our endpoints? |
I've tested it with Docker but will take a look right now. |
This was the last one where we used compat one, now we switched to libpod one - cockpit-project/cockpit-podman#456 However it is broken in both:
I updated podman yesterday from fedora repos and now cannot use c-podman at all.
|
Thanks, @marusak! |
Fix an error where an absent "filters" parameter led to JSON parsing errors. Fixes: containers#7078 Signed-off-by: Valentin Rothberg <[email protected]>
Add a simple test to exercise the events API without the "filters" parameter. Prevents regressing on containers#7078. Signed-off-by: Valentin Rothberg <[email protected]>
Fix an error where an absent "filters" parameter led to JSON parsing errors. Fixes: containers#7078 Signed-off-by: Valentin Rothberg <[email protected]>
Add a simple test to exercise the events API without the "filters" parameter. Prevents regressing on containers#7078. Signed-off-by: Valentin Rothberg <[email protected]>
[2.0] events parsing fix #7078
Can you please make a new release with this? 2.0.3 now made it into Fedora 32 as well, and it's completely breaking cockpit-podman. Thanks! |
FWIV we already got report about that in cockpit-project/cockpit-podman#469, our test image refresh is blocked due to that in cockpit-project/bots#1109 and every team member who touched c-podman in last week had problem with this. I suspect that more people will hit this problem as they update podman in their fedoras (and we even now start to support debian, where is also broken version 2.0.3) |
We're on it. Just wrapped up other backports in #7166. |
2.0.3 breaks API: - https://bugs.debian.org/966501 - containers/podman#7078 The Debian package now ships the REST systemd units, but due to containers/podman#7190 they get "over-enabled". Hack around that.
2.0.3 breaks API: - https://bugs.debian.org/966501 - containers/podman#7078 The Debian package now ships the REST systemd units, but due to containers/podman#7190 they get "over-enabled". Hack around that.
2.0.3 breaks API: - https://bugs.debian.org/966501 - containers/podman#7078 The Debian package now ships the REST systemd units, but due to containers/podman#7190 they get "over-enabled". Hack around that.
This avoids running into the API breakage of 2.0.3: containers/podman#7078
This avoids running into the API breakage of 2.0.3: containers/podman#7078 Closes #478
Previously this used to work, now it returns this error:
Tested with podman-2.0.3-1.module+el8.3.0+7450+9ea086fe.x86_64
(breaks RHEL-8-3 gating)
The text was updated successfully, but these errors were encountered: