Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events Rest API changes in v1.12 #7078

Closed
KKoukiou opened this issue Jul 24, 2020 · 8 comments · Fixed by #7088
Closed

events Rest API changes in v1.12 #7078

KKoukiou opened this issue Jul 24, 2020 · 8 comments · Fixed by #7088
Assignees
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@KKoukiou
Copy link
Contributor

Previously this used to work, now it returns this error:

# curl -s --unix-socket /run/podman/podman.sock http://d/v1.12/events
{"cause":"unexpected end of JSON input","message":"Failed to parse parameters for /v1.12/events: unexpected end of JSON input","response":400}

Tested with podman-2.0.3-1.module+el8.3.0+7450+9ea086fe.x86_64

(breaks RHEL-8-3 gating)

@rhatdan
Copy link
Member

rhatdan commented Jul 24, 2020

Ok that is bad.

@mheon
Copy link
Member

mheon commented Jul 24, 2020

I am wondering if this was the parameter type change from @vrothberg from map[string][]stiring to map[string]map[string]bool for Docker compat.

I'm also curious as to why the Docker endpoint is being used here - thought Cockpit was using our endpoints?

@vrothberg
Copy link
Member

I've tested it with Docker but will take a look right now.

@marusak
Copy link
Contributor

marusak commented Jul 27, 2020

I'm also curious as to why the Docker endpoint is being used here - thought Cockpit was using our endpoints?

This was the last one where we used compat one, now we switched to libpod one - cockpit-project/cockpit-podman#456

However it is broken in both:

$ sudo curl -s --unix-socket /run/podman/podman.sock http://d/v1.12/events
{"cause":"unexpected end of JSON input","message":"Failed to parse parameters for /v1.12/events: unexpected end of JSON input","response":400}
$ sudo curl -s --unix-socket /run/podman/podman.sock http://d/v1.12/libpod/events
{"cause":"unexpected end of JSON input","message":"Failed to parse parameters for /v1.12/libpod/events: unexpected end of JSON input","response":400}

I updated podman yesterday from fedora repos and now cannot use c-podman at all.

$ rpm -q podman
podman-2.0.3-1.fc32.x86_64

@vrothberg
Copy link
Member

Thanks, @marusak!

vrothberg added a commit to vrothberg/libpod that referenced this issue Jul 27, 2020
Fix an error where an absent "filters" parameter led to JSON parsing
errors.

Fixes: containers#7078
Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg added a commit to vrothberg/libpod that referenced this issue Jul 27, 2020
Add a simple test to exercise the events API without the "filters"
parameter.  Prevents regressing on containers#7078.

Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg added a commit to vrothberg/libpod that referenced this issue Jul 27, 2020
Fix an error where an absent "filters" parameter led to JSON parsing
errors.

Fixes: containers#7078
Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg added a commit to vrothberg/libpod that referenced this issue Jul 27, 2020
Add a simple test to exercise the events API without the "filters"
parameter.  Prevents regressing on containers#7078.

Signed-off-by: Valentin Rothberg <[email protected]>
openshift-merge-robot added a commit that referenced this issue Jul 27, 2020
@martinpitt
Copy link
Contributor

Can you please make a new release with this? 2.0.3 now made it into Fedora 32 as well, and it's completely breaking cockpit-podman. Thanks!

@marusak
Copy link
Contributor

marusak commented Jul 31, 2020

FWIV we already got report about that in cockpit-project/cockpit-podman#469, our test image refresh is blocked due to that in cockpit-project/bots#1109 and every team member who touched c-podman in last week had problem with this. I suspect that more people will hit this problem as they update podman in their fedoras (and we even now start to support debian, where is also broken version 2.0.3)

@vrothberg
Copy link
Member

We're on it. Just wrapped up other backports in #7166.

martinpitt added a commit to martinpitt/cockpit-podman that referenced this issue Aug 1, 2020
martinpitt added a commit to martinpitt/cockpit-podman that referenced this issue Aug 2, 2020
martinpitt added a commit to martinpitt/cockpit-podman that referenced this issue Aug 3, 2020
martinpitt added a commit to martinpitt/cockpit-podman that referenced this issue Aug 3, 2020
2.0.3 breaks API:

 - https://bugs.debian.org/966501
 - containers/podman#7078

The Debian package now ships the REST systemd units, but due to
containers/podman#7190 they get
"over-enabled". Hack around that.
martinpitt added a commit to martinpitt/cockpit-podman that referenced this issue Aug 3, 2020
2.0.3 breaks API:

 - https://bugs.debian.org/966501
 - containers/podman#7078

The Debian package now ships the REST systemd units, but due to
containers/podman#7190 they get
"over-enabled". Hack around that.
marusak pushed a commit to cockpit-project/cockpit-podman that referenced this issue Aug 3, 2020
2.0.3 breaks API:

 - https://bugs.debian.org/966501
 - containers/podman#7078

The Debian package now ships the REST systemd units, but due to
containers/podman#7190 they get
"over-enabled". Hack around that.
martinpitt added a commit to martinpitt/cockpit-podman that referenced this issue Aug 3, 2020
This avoids running into the API breakage of 2.0.3:
containers/podman#7078
martinpitt added a commit to cockpit-project/cockpit-podman that referenced this issue Aug 3, 2020
This avoids running into the API breakage of 2.0.3:
containers/podman#7078

Closes #478
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants